Skip to content

Commit cf25389

Browse files
committed
Vendored packtab for Unicode index tables
Vendor harfbuzz/packtab under Tools/unicode/packtab and use it in Tools/unicode/makeunicodedata.py to generate packed lookup helpers for the main codepoint->record/type maps. Switch unicodedata and unicodectype runtime lookups to those generated helpers. Measured on macOS arm64 builds: - python.exe: 6163528 -> 6092632 bytes (-70896, -1.15%) - unicodedata.so: 772352 -> 722912 bytes (-49440, -6.40%) - combined shipped: 6935880 -> 6815544 bytes (-120336, -1.73%)
1 parent 6908372 commit cf25389

9 files changed

Lines changed: 4761 additions & 5620 deletions

File tree

Modules/unicodedata.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ _getrecord_ex(Py_UCS4 code)
8989
if (code >= 0x110000)
9090
index = 0;
9191
else {
92-
index = index1[(code>>SHIFT)];
93-
index = index2[(index<<SHIFT)+(code&((1<<SHIFT)-1))];
92+
index = unicodedata_get_record_index(code);
9493
}
9594

9695
return &_PyUnicode_Database_Records[index];

Modules/unicodedata_db.h

Lines changed: 1319 additions & 3002 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Objects/unicodectype.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,8 @@ gettyperecord(Py_UCS4 code)
4848

4949
if (code >= 0x110000)
5050
index = 0;
51-
else
52-
{
53-
index = index1[(code>>SHIFT)];
54-
index = index2[(index<<SHIFT)+(code&((1<<SHIFT)-1))];
51+
else {
52+
index = unicodetype_get_type_index(code);
5553
}
5654

5755
return &_PyUnicode_TypeRecords[index];
@@ -285,4 +283,3 @@ int _PyUnicode_IsAlpha(Py_UCS4 ch)
285283

286284
return (ctype->flags & ALPHA_MASK) != 0;
287285
}
288-

Objects/unicodetype_db.h

Lines changed: 1038 additions & 2597 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tools/unicode/makeunicodedata.py

Lines changed: 45 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#
2828

2929
import dataclasses
30+
import io
3031
import os
3132
import sys
3233
import re
@@ -36,6 +37,12 @@
3637
from textwrap import dedent
3738
from typing import Iterator, List, Optional, Set, Tuple
3839

40+
PACKTAB_DIR = os.path.join(os.path.dirname(__file__), "packtab")
41+
if PACKTAB_DIR not in sys.path:
42+
sys.path.insert(0, PACKTAB_DIR)
43+
44+
from packTab import Code, pack_table
45+
3946
SCRIPT = os.path.normpath(sys.argv[0])
4047
VERSION = "3.3"
4148

@@ -427,13 +434,15 @@ def makeunicodedata(unicode, trace):
427434
fprint(" NULL")
428435
fprint("};")
429436

430-
# split record index table
431-
index1, index2, shift = splitbins(index, trace)
432-
433-
fprint("/* index tables for the database records */")
434-
fprint("#define SHIFT", shift)
435-
Array("index1", index1).dump(fp, trace)
436-
Array("index2", index2).dump(fp, trace)
437+
fprint("/* lookup helper for the database records */")
438+
dump_packtab_lookup(
439+
fp,
440+
"unicodedata",
441+
"get_record_index",
442+
index,
443+
default=0,
444+
trace=trace,
445+
)
437446

438447
# split decomposition index table
439448
index1, index2, shift = splitbins(decomp_index, trace)
@@ -638,13 +647,15 @@ def makeunicodetype(unicode, trace):
638647
fprint("};")
639648
fprint()
640649

641-
# split decomposition index table
642-
index1, index2, shift = splitbins(index, trace)
643-
644-
fprint("/* type indexes */")
645-
fprint("#define SHIFT", shift)
646-
Array("index1", index1).dump(fp, trace)
647-
Array("index2", index2).dump(fp, trace)
650+
fprint("/* lookup helper for type indexes */")
651+
dump_packtab_lookup(
652+
fp,
653+
"unicodetype",
654+
"get_type_index",
655+
index,
656+
default=0,
657+
trace=trace,
658+
)
648659

649660
# Generate code for _PyUnicode_ToNumeric()
650661
numeric_items = sorted(numeric.items())
@@ -1283,6 +1294,26 @@ def dump(self, file, trace=0):
12831294
file.write("};\n\n")
12841295

12851296

1297+
def dump_packtab_lookup(file, namespace, func_name, data, default=0, trace=0, compression=1):
1298+
solution = pack_table(data, default=default, compression=compression)
1299+
if trace:
1300+
print(
1301+
f"{func_name}: packtab {solution.cost} bytes,"
1302+
f" {solution.nLookups} lookups, {solution.nExtraOps} extra ops",
1303+
file=sys.stderr,
1304+
)
1305+
code = Code(namespace)
1306+
solution.genCode(code, func_name, language="c", private=True)
1307+
buf = io.StringIO()
1308+
code.print_code(file=buf, language="c")
1309+
generated = buf.getvalue()
1310+
if generated.startswith("#include <stdint.h>\n\n"):
1311+
generated = generated[len("#include <stdint.h>\n\n"):]
1312+
file.write(generated)
1313+
if not generated.endswith("\n\n"):
1314+
file.write("\n")
1315+
1316+
12861317
def getsize(data):
12871318
# return smallest possible integer size for the given array
12881319
maxdata = max(data)

Tools/unicode/packtab/LICENSE

Lines changed: 201 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,201 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute must
108+
include a readable copy of the attribution notices contained
109+
within such NOTICE file, excluding those notices that do not
110+
pertain to any part of the Derivative Works, in at least one
111+
of the following places: within a NOTICE text file distributed
112+
as part of the Derivative Works; within the Source form or
113+
documentation, if provided along with the Derivative Works; or,
114+
within a display generated by the Derivative Works, if and
115+
wherever such third-party notices normally appear. The contents
116+
of the NOTICE file are for informational purposes only and
117+
do not modify the License. You may add Your own attribution
118+
notices within Derivative Works that You distribute, alongside
119+
or as an addendum to the NOTICE text from the Work, provided
120+
that such additional attribution notices cannot be construed
121+
as modifying the License.
122+
123+
You may add Your own copyright statement to Your modifications and
124+
may provide additional or different license terms and conditions
125+
for use, reproduction, or distribution of Your modifications, or
126+
for any such Derivative Works as a whole, provided Your use,
127+
reproduction, and distribution of the Work otherwise complies with
128+
the conditions stated in this License.
129+
130+
5. Submission of Contributions. Unless You explicitly state otherwise,
131+
any Contribution intentionally submitted for inclusion in the Work
132+
by You to the Licensor shall be under the terms and conditions of
133+
this License, without any additional terms or conditions.
134+
Notwithstanding the above, nothing herein shall supersede or modify
135+
the terms of any separate license agreement you may have executed
136+
with Licensor regarding such Contributions.
137+
138+
6. Trademarks. This License does not grant permission to use the trade
139+
names, trademarks, service marks, or product names of the Licensor,
140+
except as required for reasonable and customary use in describing the
141+
origin of the Work and reproducing the content of the NOTICE file.
142+
143+
7. Disclaimer of Warranty. Unless required by applicable law or
144+
agreed to in writing, Licensor provides the Work (and each
145+
Contributor provides its Contributions) on an "AS IS" BASIS,
146+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
147+
implied, including, without limitation, any warranties or conditions
148+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
149+
PARTICULAR PURPOSE. You are solely responsible for determining the
150+
appropriateness of using or redistributing the Work and assume any
151+
risks associated with Your exercise of permissions under this License.
152+
153+
8. Limitation of Liability. In no event and under no legal theory,
154+
whether in tort (including negligence), contract, or otherwise,
155+
unless required by applicable law (such as deliberate and grossly
156+
negligent acts) or agreed to in writing, shall any Contributor be
157+
liable to You for damages, including any direct, indirect, special,
158+
incidental, or consequential damages of any character arising as a
159+
result of this License or out of the use or inability to use the
160+
Work (including but not limited to damages for loss of goodwill,
161+
work stoppage, computer failure or malfunction, or any and all
162+
other commercial damages or losses), even if such Contributor
163+
has been advised of the possibility of such damages.
164+
165+
9. Accepting Warranty or Additional Liability. While redistributing
166+
the Work or Derivative Works thereof, You may choose to offer,
167+
and charge a fee for, acceptance of support, warranty, indemnity,
168+
or other liability obligations and/or rights consistent with this
169+
License. However, in accepting such obligations, You may act only
170+
on Your own behalf and on Your sole responsibility, not on behalf
171+
of any other Contributor, and only if You agree to indemnify,
172+
defend, and hold each Contributor harmless for any liability
173+
incurred by, or claims asserted against, such Contributor by reason
174+
of your accepting any such warranty or additional liability.
175+
176+
END OF TERMS AND CONDITIONS
177+
178+
APPENDIX: How to apply the Apache License to your work.
179+
180+
To apply the Apache License to your work, attach the following
181+
boilerplate notice, with the fields enclosed by brackets "[]"
182+
replaced with your own identifying information. (Don't include
183+
the brackets!) The text should be enclosed in the appropriate
184+
comment syntax for the file format. We also recommend that a
185+
file or class name and description of purpose be included on the
186+
same "printed page" as the copyright notice for easier
187+
identification within third-party archives.
188+
189+
Copyright 2019 Facebook Inc. All Rights Reserved.
190+
191+
Licensed under the Apache License, Version 2.0 (the "License");
192+
you may not use this file except in compliance with the License.
193+
You may obtain a copy of the License at
194+
195+
http://www.apache.org/licenses/LICENSE-2.0
196+
197+
Unless required by applicable law or agreed to in writing, software
198+
distributed under the License is distributed on an "AS IS" BASIS,
199+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
200+
See the License for the specific language governing permissions and
201+
limitations under the License.

0 commit comments

Comments
 (0)