Skip to content

Commit c477938

Browse files
committed
Don't retry -- network errors skip the test, anyway
1 parent cd9d5f8 commit c477938

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

Lib/test/test_urllib2net.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,19 +171,20 @@ def patched_create_connection(address, *args, **kwargs):
171171
with check_no_resource_warning(self):
172172
# Try without CacheFTPHandler
173173
warnings.filterwarnings('error', category=ResourceWarning)
174-
self._test_urls([entry], handlers=no_cache_handlers)
174+
self._test_urls([entry], handlers=no_cache_handlers,
175+
retry=False)
175176
with check_no_resource_warning(self):
176177
# Try with CacheFTPHandler (uncached)
177178
warnings.filterwarnings('error', category=ResourceWarning)
178-
self._test_urls([entry], cache_handlers)
179+
self._test_urls([entry], cache_handlers, retry=False)
179180
with check_no_resource_warning(self):
180181
# Try with CacheFTPHandler (cached)
181182
warnings.filterwarnings('error', category=ResourceWarning)
182-
self._test_urls([entry], cache_handlers)
183+
self._test_urls([entry], cache_handlers, retry=False)
183184
# Try without the mock: the handler should not use a closed connection
184185
with check_no_resource_warning(self):
185186
warnings.filterwarnings('error', category=ResourceWarning)
186-
self._test_urls([url], cache_handlers)
187+
self._test_urls([url], cache_handlers, retry=False)
187188

188189
def test_file(self):
189190
TESTFN = os_helper.TESTFN

0 commit comments

Comments
 (0)