don't try to be too clever with exceptions: if a global name raises an exception when evaluated, just color it as None

Author: antocuni

Lib/_pyrepl/fancycompleter.py

@@ -117,7 +117,7 @@ def global_matches(self, text):
                 try:
                     values.append(eval(name, self.namespace))
                 except Exception as exc:
-                    values.append(exc)
+                    values.append(None)
         if self.config.use_colors and names:
             return self.colorize_matches(names, values)
         return names

Lib/test/test_pyrepl/test_fancycompleter.py

@@ -128,21 +128,6 @@ def test_complete_global_colored_exception(self):
                 ' '
             ])
 
-    def test_complete_global_exception(self):
-        def rlcompleter_global_matches(self, text):
-            return ['trigger_exception!', 'nameerror', 'valid']
-
-        self.mock_patch.setattr(rlcompleter.Completer, 'global_matches',
-                          rlcompleter_global_matches)
-
-        compl = Completer({'valid': 42}, ColorConfig)
-        self.assertEqual(compl.global_matches(""), [
-            "\x1b[000;00m\x1b[31;01mnameerror\x1b[00m",
-            "\x1b[001;00m\x1b[31;01mtrigger_exception!\x1b[00m",
-            "\x1b[002;00m\x1b[33;01mvalid\x1b[00m",
-            " ",
-        ])
-
     def test_color_for_obj(self):
         class Config(ColorConfig):
             color_by_type = {}