fix: address comments

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

Author: yihong0618

Lib/_pyrepl/utils.py

@@ -208,8 +208,10 @@ def gen_colors_from_token_stream(
                 ):
                     span = Span.from_token(token, line_lengths)
                     yield ColorSpan(span, "soft_keyword")
-                elif (token.string in BUILTINS
-                      and not (prev_token and prev_token.type == T.OP and prev_token.string == ".")):
+                elif (
+                    token.string in BUILTINS
+                    and not (prev_token and prev_token.type == T.OP
+                                        and prev_token.string == ".")):
                     span = Span.from_token(token, line_lengths)
                     yield ColorSpan(span, "builtin")
 

Lib/test/test_pyrepl/test_utils.py

@@ -62,32 +62,21 @@ def gen_raise():
             next(pnw)
 
     def test_gen_colors_keyword_highlighting(self):
-        no_highlight_cases = [
+        cases = [
+            # no highlights
             ("a.set", [(".", "op")]),
             ("obj.list", [(".", "op")]),
             ("obj.match", [(".", "op")]),
-        ]
-        for code, expected_highlights in no_highlight_cases:
-            with self.subTest(code=code):
-                colors = list(gen_colors(code))
-                # Extract (text, tag) pairs for comparison
-                actual_highlights = []
-                for color in colors:
-                    span_text = code[color.span.start:color.span.end + 1]
-                    actual_highlights.append((span_text, color.tag))
-                self.assertEqual(actual_highlights, expected_highlights,
-                               f"In '{code}', expected {expected_highlights}, got {actual_highlights}")
-        highlight_cases = [
+            # highlights
             ("set", [("set", "builtin")]),
             ("list", [("list", "builtin")]),
         ]
-        for code, expected_highlights in highlight_cases:
+        for code, expected_highlights in cases:
             with self.subTest(code=code):
                 colors = list(gen_colors(code))
                 # Extract (text, tag) pairs for comparison
                 actual_highlights = []
                 for color in colors:
                     span_text = code[color.span.start:color.span.end + 1]
                     actual_highlights.append((span_text, color.tag))
-                self.assertEqual(actual_highlights, expected_highlights,
-                               f"In '{code}', expected {expected_highlights}, got {actual_highlights}")
+                self.assertEqual(actual_highlights, expected_highlights)

Misc/NEWS.d/next/Core_and_Builtins/2025-09-01-16-09-02.gh-issue-138318.t-WEN5.rst

@@ -1 +1,3 @@
-fix: xxx.builtins the builtins keyword should not highlight in new repl
+The default REPL now avoids highlighting built-in names (for instance :class:`set`
+    or :func:`format`) when they are used as attribute names (for instance in ``value.set``
+    or ``text.format``).