s/collapsed_out/jsonl_out/, less copying :D

Author: maurycy

Lib/test/test_profiling/test_sampling_profiler/test_collectors.py

@@ -1667,8 +1667,8 @@ def test_diff_flamegraph_load_baseline(self):
         self.assertAlmostEqual(cold_node["diff_pct"], -50.0)
 
     def test_jsonl_collector_export(self):
-        collapsed_out = tempfile.NamedTemporaryFile(delete=False)
-        self.addCleanup(close_and_unlink, collapsed_out)
+        jsonl_out = tempfile.NamedTemporaryFile(delete=False)
+        self.addCleanup(close_and_unlink, jsonl_out)
 
         collector = JsonlCollector(1000)
         run_id = collector.run_id
@@ -1706,10 +1706,10 @@ def test_jsonl_collector_export(self):
         collector.collect(test_frames3)
 
         with captured_stdout(), captured_stderr():
-            collector.export(collapsed_out.name)
+            collector.export(jsonl_out.name)
 
         # Check file contents
-        with open(collapsed_out.name, "r") as f:
+        with open(jsonl_out.name, "r") as f:
             content = f.read()
 
         lines = content.strip().split("\n")
@@ -2147,8 +2147,8 @@ def test_gecko_collector_with_location_info(self):
 
     def test_jsonl_collector_with_location_info(self):
         """Test JsonlCollector handles LocationInfo properly."""
-        collapsed_out = tempfile.NamedTemporaryFile(delete=False)
-        self.addCleanup(close_and_unlink, collapsed_out)
+        jsonl_out = tempfile.NamedTemporaryFile(delete=False)
+        self.addCleanup(close_and_unlink, jsonl_out)
 
         collector = JsonlCollector(sample_interval_usec=1000)
         run_id = collector.run_id
@@ -2164,10 +2164,10 @@ def test_jsonl_collector_with_location_info(self):
 
         # Should extract lineno from location
         with captured_stdout(), captured_stderr():
-            collector.export(collapsed_out.name)
+            collector.export(jsonl_out.name)
 
         # Check file contents
-        with open(collapsed_out.name, "r") as f:
+        with open(jsonl_out.name, "r") as f:
             content = f.read()
 
         lines = content.strip().split("\n")
@@ -2197,8 +2197,8 @@ def jsonl(obj):
 
     def test_jsonl_collector_with_none_location(self):
         """Test JsonlCollector handles None location (synthetic frames)."""
-        collapsed_out = tempfile.NamedTemporaryFile(delete=False)
-        self.addCleanup(close_and_unlink, collapsed_out)
+        jsonl_out = tempfile.NamedTemporaryFile(delete=False)
+        self.addCleanup(close_and_unlink, jsonl_out)
 
         collector = JsonlCollector(sample_interval_usec=1000)
         run_id = collector.run_id
@@ -2216,10 +2216,10 @@ def test_jsonl_collector_with_none_location(self):
 
         # Should handle None location as synthetic frame
         with captured_stdout(), captured_stderr():
-            collector.export(collapsed_out.name)
+            collector.export(jsonl_out.name)
 
         # Check file contents
-        with open(collapsed_out.name, "r") as f:
+        with open(jsonl_out.name, "r") as f:
             content = f.read()
 
         lines = content.strip().split("\n")

Lib/test/test_profiling/test_sampling_profiler/test_modes.py

@@ -238,8 +238,8 @@ def test_jsonl_collector_rspects_skip_idle(self):
         import tempfile
         import json
 
-        collapsed_out = tempfile.NamedTemporaryFile(delete=False)
-        self.addCleanup(close_and_unlink, collapsed_out)
+        jsonl_out = tempfile.NamedTemporaryFile(delete=False)
+        self.addCleanup(close_and_unlink, jsonl_out)
 
         # Create mock frames with different thread statuses
         class MockThreadInfoWithStatus:
@@ -287,10 +287,10 @@ def __init__(self, thread_id, frame_info, status):
 
         # Should only have functions from running threads (status 0)
         with captured_stdout(), captured_stderr():
-            collector_skip.export(collapsed_out.name)
+            collector_skip.export(jsonl_out.name)
 
         # Check file contents
-        with open(collapsed_out.name, "r") as f:
+        with open(jsonl_out.name, "r") as f:
             content = f.read()
 
         lines = content.strip().split("\n")
@@ -333,10 +333,10 @@ def jsonl(obj):
 
         # Should have functions from all threads
         with captured_stdout(), captured_stderr():
-            collector_no_skip.export(collapsed_out.name)
+            collector_no_skip.export(jsonl_out.name)
 
         # Check file contents
-        with open(collapsed_out.name, "r") as f:
+        with open(jsonl_out.name, "r") as f:
             content = f.read()
 
         lines = content.strip().split("\n")