code review

Author: tungol

Lib/test/test_zoneinfo/test_zoneinfo.py

@@ -18,7 +18,7 @@
 from functools import cached_property
 
 from test.support import MISSING_C_DOCSTRINGS
-from test.support.os_helper import EnvironmentVarGuard
+from test.support.os_helper import EnvironmentVarGuard, FakePath
 from test.test_zoneinfo import _support as test_support
 from test.test_zoneinfo._support import TZPATH_TEST_LOCK, ZoneInfoTestBase
 from test.support.import_helper import import_module, CleanImport
@@ -1784,7 +1784,7 @@ def test_reset_tzpath_relative_paths(self):
             ("/usr/share/zoneinfo", "../relative/path",),
             ("path/to/somewhere", "../relative/path",),
             ("/usr/share/zoneinfo", "path/to/somewhere", "../relative/path",),
-            (pathlib.Path("path/to/somewhere"),)
+            (FakePath("path/to/somewhere"),)
         ]
         for input_paths in bad_values:
             with self.subTest(input_paths=input_paths):
@@ -1797,6 +1797,8 @@ def test_tzpath_type_error(self):
             b"/etc/zoneinfo:/usr/share/zoneinfo",
             0,
             (b"/bytes/path", "/valid/path"),
+            (FakePath(b"/bytes/path"),),
+            (0,),
         ]
 
         for bad_value in bad_values:
@@ -1807,7 +1809,7 @@ def test_tzpath_type_error(self):
     def test_tzpath_attribute(self):
         tzpath_0 = [f"{DRIVE}/one", f"{DRIVE}/two"]
         tzpath_1 = [f"{DRIVE}/three"]
-        tzpath_pathlike = (pathlib.Path("{DRIVE}/usr/share/zoneinfo"),)
+        tzpath_pathlike = (FakePath(f"{DRIVE}/usr/share/zoneinfo"),)
 
         with self.tzpath_context(tzpath_0):
             query_0 = self.module.TZPATH

Lib/zoneinfo/_tzpath.py

@@ -14,8 +14,7 @@ def _reset_tzpath(to=None, stacklevel=4):
             )
 
         tzpaths = [os.fspath(p) for p in tzpaths]
-        nonstr_paths = [p for p in tzpaths if not isinstance(p, str)]
-        if nonstr_paths:
+        if not all(isinstance(p, str) for p in tzpaths):
             raise TypeError(
                 "All elements of a tzpath sequence must be strings or "
                 "os.PathLike objects which convert to strings."