Skip to content

Commit 753df7a

Browse files
committed
Address code review
1 parent 1ee0825 commit 753df7a

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

Objects/genobject.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ gen_set_name(PyObject *self, PyObject *value, void *Py_UNUSED(ignored))
720720
return -1;
721721
}
722722
Py_BEGIN_CRITICAL_SECTION(self);
723-
_PyObject_XSetRefDelayed(&op->gi_name, value);
723+
_PyObject_XSetRefDelayed(&op->gi_name, Py_NewRef(value));
724724
Py_END_CRITICAL_SECTION();
725725
return 0;
726726
}
@@ -744,7 +744,7 @@ gen_set_qualname(PyObject *self, PyObject *value, void *Py_UNUSED(ignored))
744744
return -1;
745745
}
746746
Py_BEGIN_CRITICAL_SECTION(self);
747-
_PyObject_XSetRefDelayed(&op->gi_qualname, value);
747+
_PyObject_XSetRefDelayed(&op->gi_qualname, Py_NewRef(value));
748748
Py_END_CRITICAL_SECTION();
749749
return 0;
750750
}

Objects/obmalloc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1236,7 +1236,7 @@ void
12361236
_PyObject_XSetRefDelayed(PyObject **ptr, PyObject *value)
12371237
{
12381238
PyObject *old = *ptr;
1239-
FT_ATOMIC_STORE_PTR_RELEASE(*ptr, Py_NewRef(value));
1239+
FT_ATOMIC_STORE_PTR_RELEASE(*ptr, value);
12401240
_PyObject_XDecRefDelayed(old);
12411241
}
12421242
#endif

0 commit comments

Comments
 (0)