use static const instead of C99 compound literals

picnixz · picnixz · commit 735d8ae090c6 · 2026-04-14T20:01:17.000+02:00
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
@@ -1677,7 +1677,8 @@ fix_error_int(const char *fmt)
 }
 
 // Return 0 if PTR represents "false", and 1 otherwise.
-#define UNPACK_TO_BOOL(PTR) (memcmp((PTR), &(_Bool){0}, sizeof(_Bool)) != 0)
+static const _Bool bool_false = 0;
+#define UNPACK_TO_BOOL(PTR) (memcmp((PTR), &bool_false, sizeof(_Bool)) != 0)
 
 /* Accept integer objects or objects with an __index__() method. */
 static long
diff --git a/Tools/c-analyzer/cpython/globals-to-fix.tsv b/Tools/c-analyzer/cpython/globals-to-fix.tsv
@@ -357,7 +357,7 @@ Modules/_testclinic.c	-	TestClass	-
 ##################################
 ## global non-objects to fix in builtin modules
 
-# <none>
+Objects/memoryobject.c	-	bool_false	-
 
 
 ##################################

Original file line number	Diff line number	Diff line change
`@@ -1677,7 +1677,8 @@ fix_error_int(const char *fmt)`
`1677`	`1677`	`}`
`1678`	`1678`
`1679`	`1679`	`// Return 0 if PTR represents "false", and 1 otherwise.`
`1680`		`-#define UNPACK_TO_BOOL(PTR) (memcmp((PTR), &(_Bool){0}, sizeof(_Bool)) != 0)`
	`1680`	`+static const _Bool bool_false = 0;`
	`1681`	`+#define UNPACK_TO_BOOL(PTR) (memcmp((PTR), &bool_false, sizeof(_Bool)) != 0)`
`1681`	`1682`
`1682`	`1683`	`/* Accept integer objects or objects with an __index__() method. */`
`1683`	`1684`	`static long`