Benedikts suggestions

Author: StanFromIreland

Doc/library/datetime.rst

@@ -2432,7 +2432,7 @@ Class attributes:
 
 :class:`date`, :class:`.datetime`, and :class:`.time` objects all support a
 ``strftime(format)`` method, to create a string representing the time under the
-control of an explicit format string.
+control of an explicit format string. The methods only accept ASCII digits.
 
 Conversely, the :meth:`date.strptime`, :meth:`datetime.strptime` and
 :meth:`time.strptime` class methods create an object from a string
@@ -2611,6 +2611,9 @@ differences between platforms in handling of unsupported format specifiers.
 .. versionadded:: 3.12
    ``%:z`` was added.
 
+.. versionchanged:: next
+   Digits must be ASCII
+
 Technical Detail
 ^^^^^^^^^^^^^^^^
 

Doc/whatsnew/3.14.rst

@@ -504,6 +504,11 @@ datetime
 * Add :meth:`datetime.time.strptime` and :meth:`datetime.date.strptime`.
   (Contributed by Wannes Boeykens in :gh:`41431`.)
 
+* The ``strptime(format)`` methods: :meth:`datetime.date.strptime`,
+  :meth:`datetime.datetime.strptime` and :meth:`datetime.time.strptime`
+  only accept ASCII digits.
+  (Contributed by Stan Ulbrych in :gh:`131008`
+
 decimal
 -------
 

Lib/_strptime.py

@@ -286,23 +286,23 @@ def __init__(self, locale_time=None):
         base = super()
         mapping = {
             # The " [1-9]" part of the regex is to make %c from ANSI C work
-            'd': r"(?P<d>3[0-1]|[1-2]\d|0[1-9]|[1-9]| [1-9])",
+            'd': r"(?P<d>3[0-1]|[1-2][0-9]|0[1-9]|[1-9]| [1-9])",
             'f': r"(?P<f>[0-9]{1,6})",
-            'H': r"(?P<H>2[0-3]|[0-1]\d|\d)",
+            'H': r"(?P<H>2[0-3]|[0-1][0-9]|[0-9])",
             'I': r"(?P<I>1[0-2]|0[1-9]|[1-9]| [1-9])",
-            'G': r"(?P<G>\d\d\d\d)",
-            'j': r"(?P<j>36[0-6]|3[0-5]\d|[1-2]\d\d|0[1-9]\d|00[1-9]|[1-9]\d|0[1-9]|[1-9])",
+            'G': r"(?P<G>[0-9][0-9][0-9][0-9])",
+            'j': r"(?P<j>36[0-6]|3[0-5][0-9]|[1-2][0-9][0-9]|0[1-9][0-9]|00[1-9]|[1-9][0-9]|0[1-9]|[1-9])",
             'm': r"(?P<m>1[0-2]|0[1-9]|[1-9])",
-            'M': r"(?P<M>[0-5]\d|\d)",
-            'S': r"(?P<S>6[0-1]|[0-5]\d|\d)",
-            'U': r"(?P<U>5[0-3]|[0-4]\d|\d)",
+            'M': r"(?P<M>[0-5][0-9]|[0-9])",
+            'S': r"(?P<S>6[0-1]|[0-5][0-9]|[0-9])",
+            'U': r"(?P<U>5[0-3]|[0-4][0-9]|[0-9])",
             'w': r"(?P<w>[0-6])",
             'u': r"(?P<u>[1-7])",
-            'V': r"(?P<V>5[0-3]|0[1-9]|[1-4]\d|\d)",
+            'V': r"(?P<V>5[0-3]|0[1-9]|[1-4][0-9]|[0-9])",
             # W is set below by using 'U'
-            'y': r"(?P<y>\d\d)",
-            'Y': r"(?P<Y>\d\d\d\d)",
-            'z': r"(?P<z>[+-]\d\d:?[0-5]\d(:?[0-5]\d(\.\d{1,6})?)?|(?-i:Z))",
+            'y': r"(?P<y>[0-9][0-9])",
+            'Y': r"(?P<Y>[0-9][0-9][0-9][0-9])",
+            'z': r"(?P<z>[+-][0-9][0-9]:?[0-5][0-9](:?[0-5][0-9](\.[0-9]{1,6})?)?|(?-i:Z))",
             'A': self.__seqToRE(self.locale_time.f_weekday, 'A'),
             'a': self.__seqToRE(self.locale_time.a_weekday, 'a'),
             'B': self.__seqToRE(self.locale_time.f_month[1:], 'B'),
@@ -313,8 +313,8 @@ def __init__(self, locale_time=None):
                                 'Z'),
             '%': '%'}
         for d in 'dmyHIMS':
-            mapping['O' + d] = r'(?P<%s>\d\d|\d| \d)' % d
-        mapping['Ow'] = r'(?P<w>\d)'
+            mapping['O' + d] = r'(?P<%s>[0-9][0-9]|[0-9]| [0-9])' % d
+        mapping['Ow'] = r'(?P<w>[0-9])'
         mapping['W'] = mapping['U'].replace('U', 'W')
         base.__init__(mapping)
         base.__setitem__('X', self.pattern(self.locale_time.LC_time))
@@ -380,7 +380,7 @@ def repl(m):
 
     def compile(self, format):
         """Return a compiled re object for the format string."""
-        return re_compile(self.pattern(format), ASCII | IGNORECASE)
+        return re_compile(self.pattern(format), IGNORECASE)
 
 _cache_lock = _thread_allocate_lock()
 # DO NOT modify _TimeRE_cache or _regex_cache without acquiring the cache lock

Lib/test/datetimetester.py

@@ -4039,7 +4039,7 @@ def test_strptime_tz(self):
         self.assertEqual(strptime("UTC", "%Z").tzinfo, None)
 
     def test_strptime_errors(self):
-        for tzstr in ("-2400", "-000", "z"):
+        for tzstr in ("-2400", "-000", "z", "٢"):
             with self.assertRaises(ValueError):
                 self.theclass.strptime(tzstr, "%z")
 

Misc/NEWS.d/next/Library/2025-03-09-11-01-00.gh-issue-83461.auwd13.rst

@@ -1 +1,2 @@
-:func:`datetime.datetime.strptime` now only accepts ASCII input.
+:meth:`datetime.date.strptime`, :meth:`datetime.datetime.strptime` and
+:meth:`datetime.time.strptime` now only accept ASCII digits.