Apply suggestions from review

Author: wiomoc

Lib/test/clinic.test.c

@@ -1614,15 +1614,15 @@ test_Py_ssize_t_converter
     c: Py_ssize_t(accept={int, NoneType}) = 56
     d: Py_ssize_t(accept={int}, allow_negative=False) = 78
     e: Py_ssize_t(accept={int, NoneType}, allow_negative=False) = 90
-    f: Py_ssize_t(accept={int}, allow_negative=True) = 12
-    g: Py_ssize_t(accept={int, NoneType}, allow_negative=True) = 34
+    f: Py_ssize_t(accept={int}, allow_negative=True) = -12
+    g: Py_ssize_t(accept={int, NoneType}, allow_negative=True) = -34
     /
 
 [clinic start generated code]*/
 
 PyDoc_STRVAR(test_Py_ssize_t_converter__doc__,
-"test_Py_ssize_t_converter($module, a=12, b=34, c=56, d=78, e=90, f=12,\n"
-"                          g=34, /)\n"
+"test_Py_ssize_t_converter($module, a=12, b=34, c=56, d=78, e=90, f=-12,\n"
+"                          g=-34, /)\n"
 "--\n"
 "\n");
 
@@ -1643,8 +1643,8 @@ test_Py_ssize_t_converter(PyObject *module, PyObject *const *args, Py_ssize_t na
     Py_ssize_t c = 56;
     Py_ssize_t d = 78;
     Py_ssize_t e = 90;
-    Py_ssize_t f = 12;
-    Py_ssize_t g = 34;
+    Py_ssize_t f = -12;
+    Py_ssize_t g = -34;
 
     if (!_PyArg_CheckPositional("test_Py_ssize_t_converter", nargs, 0, 7)) {
         goto exit;
@@ -1743,7 +1743,7 @@ static PyObject *
 test_Py_ssize_t_converter_impl(PyObject *module, Py_ssize_t a, Py_ssize_t b,
                                Py_ssize_t c, Py_ssize_t d, Py_ssize_t e,
                                Py_ssize_t f, Py_ssize_t g)
-/*[clinic end generated code: output=8721e4925ea46578 input=0d80cb5c942b6e0f]*/
+/*[clinic end generated code: output=2034b285dd317556 input=a25bac8ecf2890aa]*/
 
 
 /*[clinic input]

Lib/test/test_clinic.py

@@ -3211,8 +3211,8 @@ def test_py_ssize_t_converter(self):
             ac_tester.py_ssize_t_converter(12, 34, 56, -1)
         with self.assertRaises(ValueError):
             ac_tester.py_ssize_t_converter(12, 34, 56, 78, -1)
-        self.assertEqual(ac_tester.py_ssize_t_converter(), (12, 34, 56, 78, 90, -1, -1))
-        self.assertEqual(ac_tester.py_ssize_t_converter(1, 2, None, 3, None, 4, None), (1, 2, 56, 3, 90, 4, -1))
+        self.assertEqual(ac_tester.py_ssize_t_converter(), (12, 34, 56, 78, 90, -12, -34))
+        self.assertEqual(ac_tester.py_ssize_t_converter(1, 2, None, 3, None, 4, None), (1, 2, 56, 3, 90, 4, -34))
 
     def test_slice_index_converter(self):
         from _testcapi import PY_SSIZE_T_MIN, PY_SSIZE_T_MAX

Modules/_testclinic.c

@@ -445,8 +445,8 @@ py_ssize_t_converter
     c: Py_ssize_t(accept={int, NoneType}) = 56
     d: Py_ssize_t(accept={int}, allow_negative=False) = 78
     e: Py_ssize_t(accept={int, NoneType}, allow_negative=False) = 90
-    f: Py_ssize_t(accept={int}, allow_negative=False) = -1
-    g: Py_ssize_t(accept={int, NoneType}, allow_negative=False) = -1
+    f: Py_ssize_t(accept={int}, allow_negative=False) = -12
+    g: Py_ssize_t(accept={int, NoneType}, allow_negative=False) = -34
     /
 
 [clinic start generated code]*/
@@ -455,7 +455,7 @@ static PyObject *
 py_ssize_t_converter_impl(PyObject *module, Py_ssize_t a, Py_ssize_t b,
                           Py_ssize_t c, Py_ssize_t d, Py_ssize_t e,
                           Py_ssize_t f, Py_ssize_t g)
-/*[clinic end generated code: output=ecf8e1a4a9abc95e input=d4571dd2ba885665]*/
+/*[clinic end generated code: output=ecf8e1a4a9abc95e input=d3b8f1f6efccf4b2]*/
 {
     RETURN_PACKED_ARGS(7, PyLong_FromSsize_t, Py_ssize_t, a, b, c, d, e, f, g);
 }

Modules/clinic/_testclinic.c.h

@@ -46,6 +46,7 @@ _Py_convert_optional_to_non_negative_ssize_t(PyObject *obj, void *result)
     return 1;
 }
 
+
 /* Helper for mkvalue() to scan the length of a format */
 
 static Py_ssize_t