Skip to content

Commit 530c2e8

Browse files
johnslavika12k
andcommitted
Change default message for NameError to "name '...' is not defined"
Co-authored-by: Aaron Wieczorek <aaronw@fastmail.com>
1 parent 0bebeec commit 530c2e8

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

Lib/test/test_exceptions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2020,7 +2020,7 @@ def f():
20202020
sys.__excepthook__(*sys.exc_info())
20212021

20222022
# 'spam' should appear even when message was empty.
2023-
self.assertIn("'spam'", err.getvalue())
2023+
self.assertIn("name 'spam' is not defined", err.getvalue())
20242024

20252025
# Note: name suggestion tests live in `test_traceback`.
20262026

Lib/test/test_traceback.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4942,8 +4942,8 @@ def func():
49424942
exc.args = ()
49434943
raise
49444944
actual = self.get_suggestion(func)
4945-
self.assertIn("'spam'", actual)
4946-
self.assertIn("'span'?", actual)
4945+
self.assertIn("name 'spam' is not defined", actual)
4946+
self.assertIn("Did you mean: 'span'?", actual)
49474947

49484948

49494949
class PurePythonSuggestionFormattingTests(

Lib/traceback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1133,7 +1133,7 @@ def __init__(self, exc_type, exc_value, exc_traceback, *, limit=None,
11331133
obj_type_name = object.__getattribute__(obj_type, "__name__")
11341134
self._str = f"{obj_type_name!r} object has no attribute {wrong_name!r}"
11351135
else: # NameError
1136-
self._str = repr(wrong_name)
1136+
self._str = f"name {wrong_name!r} is not defined"
11371137
if suggestion:
11381138
self._str += f". Did you mean: '{suggestion}'?"
11391139
if issubclass(exc_type, NameError):

0 commit comments

Comments
 (0)