refine test

Author: picnixz

Lib/test/test_pyexpat.py

@@ -9,12 +9,11 @@
 from io import BytesIO
 from test import support
 from test.support import os_helper
-
+from test.support import sortdict
+from unittest import mock
 from xml.parsers import expat
 from xml.parsers.expat import errors
 
-from test.support import sortdict
-
 
 class SetAttributeTest(unittest.TestCase):
     def setUp(self):
@@ -440,9 +439,12 @@ def test_change_character_data_handler_in_callback(self):
         def handler(*args):
             parser.CharacterDataHandler = None
 
+        handler_wrapper = unittest.mock.Mock(wraps=handler)
         parser = expat.ParserCreate()
-        parser.CharacterDataHandler = handler
+        parser.CharacterDataHandler = handler_wrapper
         parser.Parse(b"<a>1<b/>2<c></c>3<!--abc-->4<!--def-->5</a> ", True)
+        handler_wrapper.assert_called_once()
+        self.assertIsNone(parser.CharacterDataHandler)
 
 
 # Test handling of exception from callback:
@@ -603,7 +605,7 @@ def test_unchanged_size(self):
     def test_disabling_buffer(self):
         xml1 = b"<?xml version='1.0' encoding='iso8859'?><a>" + b'a' * 512
         xml2 = b'b' * 1024
-        xml3 = b'c' * 1024 + b'</a>';
+        xml3 = b'c' * 1024 + b'</a>'
         parser = expat.ParserCreate()
         parser.CharacterDataHandler = self.counting_handler
         parser.buffer_text = 1