PYTHON_TRACEBACK_TIMESTAMPS=1 required to enable their display.

Author: gpshead

Lib/test/test_sys.py

@@ -1595,13 +1595,13 @@ def inner():
         class C(object): pass
         check(C.__dict__, size('P'))
         # BaseException
-        check(BaseException(), size('6Pb'))
+        check(BaseException(), size('3Pq3Pb'))
         # UnicodeEncodeError
-        check(UnicodeEncodeError("", "", 0, 0, ""), size('6Pb 2P2nP'))
+        check(UnicodeEncodeError("", "", 0, 0, ""), size('3Pq3Pb 2P2nP'))
         # UnicodeDecodeError
-        check(UnicodeDecodeError("", b"", 0, 0, ""), size('6Pb 2P2nP'))
+        check(UnicodeDecodeError("", b"", 0, 0, ""), size('3Pq3Pb 2P2nP'))
         # UnicodeTranslateError
-        check(UnicodeTranslateError("", 0, 1, ""), size('6Pb 2P2nP'))
+        check(UnicodeTranslateError("", 0, 1, ""), size('3Pq3Pb 2P2nP'))
         # ellipses
         check(Ellipsis, size(''))
         # EncodingMap

Lib/traceback.py

@@ -3,6 +3,7 @@
 import collections.abc
 import itertools
 import linecache
+import os
 import sys
 import textwrap
 import warnings
@@ -17,6 +18,10 @@
            'FrameSummary', 'StackSummary', 'TracebackException',
            'walk_stack', 'walk_tb', 'print_list']
 
+
+ENABLE_TRACEBACK_TIMESTAMPS = os.environb.get(b"PYTHON_TRACEBACK_TIMESTAMPS", b"") == b"1"
+
+
 #
 # Formatting and printing lists of traceback lines.
 #
@@ -182,7 +187,7 @@ def format_exception_only(exc, /, value=_sentinel, *, show_group=False, **kwargs
 def _format_final_exc_line(etype, value, *, insert_final_newline=True, colorize=False, timestamp=0):
     valuestr = _safe_string(value, 'exception')
     end_char = "\n" if insert_final_newline else ""
-    ts = f" <@t={timestamp:.6f}>" if timestamp else ""
+    ts = f" <@T={timestamp:.6f}>" if timestamp else ""
     if colorize:
         timestamp = f"{ANSIColors.GREY}{ts}{ANSIColors.RESET}" if timestamp else ""
         if value is None or not valuestr:
@@ -1007,7 +1012,7 @@ class TracebackException:
     - :attr:`__cause__` A TracebackException of the original *__cause__*.
     - :attr:`__context__` A TracebackException of the original *__context__*.
     - :attr:`__notes__` A reference to the original *__notes__* list.
-    - :attr:`timestamp` When the original exception was created (seconds).
+    - :attr:`_timestamp` When the exception was created (seconds), if enabled.
     - :attr:`exceptions` For exception groups - a list of TracebackException
       instances for the nested *exceptions*.  ``None`` for other exceptions.
     - :attr:`__suppress_context__` The *__suppress_context__* value from the
@@ -1061,7 +1066,10 @@ def __init__(self, exc_type, exc_value, exc_traceback, *, limit=None,
             self.__notes__ = [
                 f'Ignored error getting __notes__: {_safe_string(e, '__notes__', repr)}']
 
-        self.timestamp = exc_value.__timestamp_ns__ / 1_000_000_000
+        if ENABLE_TRACEBACK_TIMESTAMPS:
+            self._timestamp = exc_value.__timestamp_ns__ / 1_000_000_000
+        else:
+            self._timestamp = 0
 
         self._is_syntax_error = False
         self._have_exc_type = exc_type is not None
@@ -1234,22 +1242,22 @@ def format_exception_only(self, *, show_group=False, _depth=0, **kwargs):
 
         indent = 3 * _depth * ' '
         if not self._have_exc_type:
-            yield indent + _format_final_exc_line(None, self._str, colorize=colorize, timestamp=self.timestamp)
+            yield indent + _format_final_exc_line(None, self._str, colorize=colorize, timestamp=self._timestamp)
             return
 
         stype = self.exc_type_str
         if not self._is_syntax_error:
             if _depth > 0:
                 # Nested exceptions needs correct handling of multiline messages.
                 formatted = _format_final_exc_line(
-                    stype, self._str, insert_final_newline=False, colorize=colorize, timestamp=self.timestamp
+                    stype, self._str, insert_final_newline=False, colorize=colorize, timestamp=self._timestamp
                 ).split('\n')
                 yield from [
                     indent + l + '\n'
                     for l in formatted
                 ]
             else:
-                yield _format_final_exc_line(stype, self._str, colorize=colorize, timestamp=self.timestamp)
+                yield _format_final_exc_line(stype, self._str, colorize=colorize, timestamp=self._timestamp)
         else:
             yield from [indent + l for l in self._format_syntax_error(stype, colorize=colorize)]
 

Objects/exceptions.c

@@ -186,14 +186,18 @@ BaseException_repr(PyBaseExceptionObject *self)
     PyObject *res;
     Py_BEGIN_CRITICAL_SECTION(self);
     const char *name = _PyType_Name(Py_TYPE(self));
+    // TODO: check the env var at startup and control timestamp inclusion here.
     if (PyTuple_GET_SIZE(self->args) == 1) {
-        res = PyUnicode_FromFormat("%s(%R) [@t=%lldns]", name,
-                                    PyTuple_GET_ITEM(self->args, 0),
-                                    self->timestamp_ns);
+//        res = PyUnicode_FromFormat("%s(%R) [@t=%lldns]", name,
+//                                    PyTuple_GET_ITEM(self->args, 0),
+//                                    self->timestamp_ns);
+        res = PyUnicode_FromFormat("%s(%R)", name,
+                                    PyTuple_GET_ITEM(self->args, 0));
     }
     else {
-        res = PyUnicode_FromFormat("%s%R [@t=%lldns]", name, self->args,
-                                   self->timestamp_ns);
+//        res = PyUnicode_FromFormat("%s%R [@t=%lldns]", name, self->args,
+//                                   self->timestamp_ns);
+        res = PyUnicode_FromFormat("%s%R", name, self->args);
     }
     Py_END_CRITICAL_SECTION();
     return res;