fix(test_httplib.py): Fix logging in tests

Author: CuriousLearner

Lib/http/client.py

@@ -320,9 +320,9 @@ def begin(self):
 
         self.headers = self.msg = parse_headers(self.fp)
 
-        if _log.isEnabledFor(logging.DEBUG):
+        if _log.isEnabledFor(logging.INFO):
             for hdr in self.headers:
-                _log.debug("Received header: ('%s': '%s')", hdr, self.headers[hdr])
+                _log.info("Received header: ('%s': '%s')", hdr, self.headers[hdr])
 
         # are we using the chunked-style of transfer encoding?
         tr_enc = self.headers.get("transfer-encoding")
@@ -1065,7 +1065,7 @@ def _send_output(self, message_body=None, encode_chunked=False):
             for chunk in chunks:
                 if not chunk:
                     if self.debuglevel > 0:
-                        print('Zero length chunk ignored')
+                        _log.info('Zero length chunk ignored')
                     continue
 
                 if encode_chunked and self._http_vsn == 11:
@@ -1334,7 +1334,11 @@ def getresponse(self):
         if self.__state != _CS_REQ_SENT or self.__response:
             raise ResponseNotReady(self.__state)
 
-        response = self.response_class(self.sock, method=self._method)
+        if self.debuglevel > 0:
+            response = self.response_class(
+                self.sock, self.debuglevel, method=self._method)
+        else:
+            response = self.response_class(self.sock, method=self._method)
 
         try:
             try:

Lib/test/test_httplib.py

@@ -3,6 +3,8 @@
 import io
 import itertools
 import os
+import sys
+import logging
 import array
 import socket
 import threading
@@ -352,12 +354,16 @@ def test_headers_debuglevel(self):
         )
         sock = FakeSocket(body)
         resp = client.HTTPResponse(sock, debuglevel=1)
+        logging.basicConfig(level=logging.INFO)
         with support.captured_stdout() as output:
+            output_handler = logging.StreamHandler(output)
+            _logger = logging.getLogger('http.client')
+            _logger.addHandler(output_handler)
             resp.begin()
         lines = output.getvalue().splitlines()
-        self.assertEqual(lines[0], "reply: 'HTTP/1.1 200 OK\\r\\n'")
-        self.assertEqual(lines[1], "header: First: val")
-        self.assertEqual(lines[2], "header: Second: val")
+        self.assertEqual(lines[0], "Received response: 200 OK")
+        self.assertEqual(lines[1], "Received header: ('First': 'val')")
+        self.assertEqual(lines[2], "Received header: ('Second': 'val')")
 
 
 class TransferEncodingTest(TestCase):
@@ -1928,7 +1934,11 @@ def test_tunnel_debuglog(self):
         self.conn._create_connection = self._create_connection(response_text)
         self.conn.set_tunnel('destination.com')
 
+        logging.basicConfig(level=logging.INFO)
         with support.captured_stdout() as output:
+            output_handler = logging.StreamHandler(output)
+            _logger = logging.getLogger('http.client')
+            _logger.addHandler(output_handler)
             self.conn.request('PUT', '/', '')
         lines = output.getvalue().splitlines()
         self.assertIn('header: {}'.format(expected_header), lines)