gh-137928: Move size validation helper to module level in multiprocessing.heap

Author: acabelloj

Lib/multiprocessing/heap.py

@@ -20,6 +20,12 @@
 
 __all__ = ['BufferWrapper']
 
+#
+# Module constants
+#
+
+_MAXSIZE = sys.maxsize
+
 #
 # Inheritable class which wraps an mmap, and from which blocks can be allocated
 #
@@ -108,6 +114,17 @@ def rebuild_arena(size, dupfd):
 
     reduction.register(Arena, reduce_arena)
 
+#
+# Validation helpers
+#
+
+def _validate_size(size):
+    """Validate requested size; raise ValueError if < 0, OverflowError if >= _MAXSIZE."""
+    if size < 0:
+        raise ValueError("Size {0:n} out of range".format(size))
+    if _MAXSIZE <= size:
+        raise OverflowError("Size {0:n} too large".format(size))
+
 #
 # Class allowing allocation of chunks of memory from arenas
 #
@@ -155,15 +172,6 @@ def _roundup(n, alignment):
         mask = alignment - 1
         return (n + mask) & ~mask
 
-    @staticmethod
-    # Bind sys.maxsize once at function definition time to avoid global lookups.
-    def _validate_size(size, _maxsize=sys.maxsize):
-        """Validate requested size; raise ValueError if < 0, OverflowError if >= _maxsize."""
-        if size < 0:
-            raise ValueError("Size {0:n} out of range".format(size))
-        if _maxsize <= size:
-            raise OverflowError("Size {0:n} too large".format(size))
-
     def _new_arena(self, size):
         # Create a new arena with at least the given *size*
         length = self._roundup(max(self._size, size), mmap.PAGESIZE)
@@ -304,7 +312,7 @@ def free(self, block):
 
     def malloc(self, size):
         # return a block of right size (possibly rounded up)
-        Heap._validate_size(size)
+        _validate_size(size)
         if os.getpid() != self._lastpid:
             self.__init__()                     # reinitialize after fork
         with self._lock:
@@ -330,7 +338,7 @@ class BufferWrapper(object):
     _heap = Heap()
 
     def __init__(self, size):
-        Heap._validate_size(size)
+        _validate_size(size)
         block = BufferWrapper._heap.malloc(size)
         self._state = (block, size)
         util.Finalize(self, BufferWrapper._heap.free, args=(block,))