Remove redundant decref in _PyLong_Negate

eendebakpt · eendebakpt · commit 19cbe693a476 · 2025-12-21T21:06:01.000+01:00
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -344,8 +344,6 @@ medium_from_stwodigits(stwodigits x)
 }
 
 
-/* If a freshly-allocated int is already shared, it must
-   be a small integer, so negating it must go to PyLong_FromLong */
 Py_LOCAL_INLINE(void)
 _PyLong_Negate(PyLongObject **x_p)
 {
@@ -357,8 +355,10 @@ _PyLong_Negate(PyLongObject **x_p)
         return;
     }
 
-    *x_p = _PyLong_FromSTwoDigits(-medium_value(x));
-    Py_DECREF(x);
+    /* If a freshly-allocated int is already shared, it must
+    be a small integer, so negating it will fit a single digit */
+    assert(_long_is_small_int((PyObject *)x));
+    *x_p = (PyLongObject *)_PyLong_FromSTwoDigits(-medium_value(x));
 }
 
 #define PYLONG_FROM_INT(UINT_TYPE, INT_TYPE, ival)                                  \

Original file line number	Diff line number	Diff line change
`@@ -344,8 +344,6 @@ medium_from_stwodigits(stwodigits x)`
`344`	`344`	`}`
`345`	`345`
`346`	`346`
`347`		`-/* If a freshly-allocated int is already shared, it must`
`348`		`- be a small integer, so negating it must go to PyLong_FromLong */`
`349`	`347`	`Py_LOCAL_INLINE(void)`
`350`	`348`	`_PyLong_Negate(PyLongObject **x_p)`
`351`	`349`	`{`
`@@ -357,8 +355,10 @@ _PyLong_Negate(PyLongObject **x_p)`
`357`	`355`	`return;`
`358`	`356`	`}`
`359`	`357`
`360`		`- *x_p = _PyLong_FromSTwoDigits(-medium_value(x));`
`361`		`- Py_DECREF(x);`
	`358`	`+ /* If a freshly-allocated int is already shared, it must`
	`359`	`+ be a small integer, so negating it will fit a single digit */`
	`360`	`+ assert(_long_is_small_int((PyObject *)x));`
	`361`	`+ x_p = (PyLongObject )_PyLong_FromSTwoDigits(-medium_value(x));`
`362`	`362`	`}`
`363`	`363`
`364`	`364`	`#define PYLONG_FROM_INT(UINT_TYPE, INT_TYPE, ival) \`