Skip to content

Commit 01e89c3

Browse files
committed
use parser.exit() instead of print + sys.exit()
1 parent 7be23f0 commit 01e89c3

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

Lib/mimetypes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -694,16 +694,16 @@ def _main(args=None):
694694
if guess:
695695
print(guess)
696696
else:
697-
print(f"error: unknown type {gtype}", file=sys.stderr)
698-
sys.exit(1)
697+
# do not use parser.error() as it prints a help message
698+
parser.exit(1, f"error: unknown type {gtype}\n")
699699
else:
700700
for gtype in args.type:
701701
guess, encoding = guess_type(gtype, not args.lenient)
702702
if guess:
703703
print('type:', guess, 'encoding:', encoding)
704704
else:
705-
print(f"error: media type unknown for {gtype}", file=sys.stderr)
706-
sys.exit(1)
705+
# do not use parser.error() as it prints a help message
706+
parser.exit(1, f"error: media type unknown for {gtype}\n")
707707

708708

709709
if __name__ == '__main__':

Lib/test/test_mimetypes.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
import sys
66
import tempfile
77
import unittest.mock
8-
8+
from os import linesep
9+
from platform import win32_edition
910
from test import support
1011
from test.support import os_helper
1112
from test.support.script_helper import run_python_until_end
12-
from platform import win32_edition
1313

1414
try:
1515
import _winapi
@@ -422,30 +422,30 @@ def test_invalid_option(self):
422422
def test_guess_extension(self):
423423
retcode, out, err = self.mimetypes_cmd('-l', '-e', 'image/jpg')
424424
self.assertEqual(retcode, 0)
425-
self.assertEqual(out, '.jpg\n')
425+
self.assertEqual(out, f'.jpg{linesep}')
426426
self.assertEqual(err, '')
427427

428428
retcode, out, err = self.mimetypes_cmd('-e', 'image/jpg')
429429
self.assertEqual(retcode, 1)
430430
self.assertEqual(out, '')
431-
self.assertEqual(err, 'error: unknown type image/jpg\n')
431+
self.assertEqual(err, f'error: unknown type image/jpg{linesep}')
432432

433433
retcode, out, err = self.mimetypes_cmd('-e', 'image/jpeg')
434434
self.assertEqual(retcode, 0)
435-
self.assertEqual(out, '.jpg\n')
435+
self.assertEqual(out, f'.jpg{linesep}')
436436
self.assertEqual(err, '')
437437

438438
def test_guess_type(self):
439439
retcode, out, err = self.mimetypes_cmd('-l', 'foo.webp')
440440
self.assertEqual(retcode, 0)
441-
self.assertEqual(out, 'type: image/webp encoding: None\n')
441+
self.assertEqual(out, f'type: image/webp encoding: None{linesep}')
442442
self.assertEqual(err, '')
443443

444-
def test_z_guess_type_conflicting_with_mimetypes(self):
444+
def test_guess_type_conflicting_with_mimetypes(self):
445445
retcode, out, err = self.mimetypes_cmd('foo.pic')
446446
self.assertEqual(retcode, 1)
447447
self.assertEqual(out, '')
448-
self.assertEqual(err, 'error: media type unknown for foo.pic\n')
448+
self.assertEqual(err, f'error: media type unknown for foo.pic{linesep}')
449449

450450

451451
if __name__ == "__main__":

0 commit comments

Comments
 (0)