Skip to content

Commit d1b07d3

Browse files
committed
Add default logger if no listener is present.
1 parent 8b8dd25 commit d1b07d3

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

kazoo/recipe/cache.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def start(self):
5858
5959
.. note::
6060
61-
This method is not thread safety.
61+
This method is not thread safe.
6262
"""
6363
if self._state == self.STATE_LATENT:
6464
self._state = self.STATE_STARTED
@@ -79,7 +79,7 @@ def close(self):
7979
8080
.. note::
8181
82-
This method is not thread safety.
82+
This method is not thread safe.
8383
"""
8484
if self._state == self.STATE_STARTED:
8585
self._state = self.STATE_CLOSED
@@ -155,7 +155,7 @@ def _find_node(self, path):
155155
def _publish_event(self, event_type, event_data=None):
156156
event = TreeEvent.make(event_type, event_data)
157157
if self._state != self.STATE_CLOSED:
158-
logger.debug('public event: {0!r}'.format(event))
158+
logger.debug('public event: %r', event)
159159
self._in_background(self._do_publish_event, event)
160160

161161
def _do_publish_event(self, event):
@@ -260,7 +260,7 @@ def _call_client(self, method_name, path, *args):
260260
method(path, *args, **kwargs).rawlink(callback)
261261

262262
def _process_watch(self, watched_event):
263-
logger.debug('process_watch: {0!r}'.format(watched_event))
263+
logger.debug('process_watch: %r', watched_event)
264264
with handle_exception(self._tree._error_listeners):
265265
if watched_event.type == EventType.CREATED:
266266
assert self._parent is None, 'unexpected CREATED on non-root'
@@ -273,7 +273,7 @@ def _process_watch(self, watched_event):
273273
self._refresh_children()
274274

275275
def _process_result(self, method_name, path, result):
276-
logger.debug('process_result: {0} {1}'.format(method_name, path))
276+
logger.debug('process_result: %s %s', method_name, path)
277277
if method_name == 'exists':
278278
assert self._parent is None, 'unexpected EXISTS on non-root'
279279
if result.successful():
@@ -308,7 +308,7 @@ def _process_result(self, method_name, path, result):
308308
else:
309309
self._publish_event(TreeEvent.NODE_ADDED, self._data)
310310
else: # pragma: no cover
311-
logger.warning('unknown operation %s' % method_name)
311+
logger.warning('unknown operation %s', method_name)
312312
self._tree._outstanding_ops -= 1
313313
return
314314

@@ -374,9 +374,11 @@ def handle_exception(listeners):
374374
try:
375375
yield
376376
except Exception as e:
377-
logger.debug('processing error: {0!r}'.format(e))
377+
logger.debug('processing error: %r', e)
378378
for listener in listeners:
379379
try:
380380
listener(e)
381381
except: # pragma: no cover
382382
logger.exception('Exception handling exception') # oops
383+
else:
384+
logger.exception('No listener to process %r', e)

0 commit comments

Comments
 (0)