Skip to content

Commit b2077a1

Browse files
committed
Fix some tests for 3.7
1 parent b9d143c commit b2077a1

2 files changed

Lines changed: 25 additions & 15 deletions

File tree

tests/python/test_base_events.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -212,17 +212,6 @@ def test_set_default_executor(self):
212212
self.loop.set_default_executor(executor)
213213
self.assertIs(executor, self.loop._default_executor)
214214

215-
async def test_getnameinfo(self):
216-
sockaddr = mock.Mock()
217-
self.loop.run_in_executor = mock.Mock()
218-
if sys.version_info >= (3, 7):
219-
await self.loop.getnameinfo(sockaddr)
220-
else:
221-
self.loop.getnameinfo(sockaddr)
222-
self.assertEqual(
223-
(None, socket.getnameinfo, sockaddr, 0), self.loop.run_in_executor.call_args[0]
224-
)
225-
226215
def test_call_soon(self):
227216
def cb():
228217
pass
@@ -1746,7 +1735,7 @@ def test_running_loop_within_a_loop(self):
17461735
@asyncio.coroutine
17471736
def runner(loop):
17481737
async def slep():
1749-
asyncio.sleep(0.1, loop=loop)
1738+
await asyncio.sleep(0.1, loop=loop)
17501739

17511740
loop.run_until_complete(slep())
17521741

tests/python/test_selector_events.py

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,14 @@ def test_sock_recv(self):
193193
f = self.loop.create_task(f)
194194
else:
195195
self.assertEqual(type(f).__name__, asyncio.Future.__name__)
196-
if sys.version_info >= (3, 6, 4):
197-
self.loop._sock_recv.assert_called_with(f, None, sock, 1024)
196+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
197+
198+
self.assertEqual(self.loop._sock_recv.call_args[0][1:],
199+
(None, sock, 1024))
200+
201+
f.cancel()
202+
with self.assertRaises(asyncio.CancelledError):
203+
self.loop.run_until_complete(f)
198204

199205
def test_sock_recv_reconnection(self):
200206
sock = mock.Mock()
@@ -207,6 +213,9 @@ def test_sock_recv_reconnection(self):
207213
fut = self.loop.sock_recv(sock, 1024)
208214
if sys.version_info >= (3, 7):
209215
fut = self.loop.create_task(fut)
216+
217+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
218+
210219
callback = self.loop.add_reader.call_args[0][1]
211220
params = self.loop.add_reader.call_args[0][2:]
212221

@@ -216,6 +225,8 @@ def test_sock_recv_reconnection(self):
216225
sock.recv.side_effect = OSError(9)
217226
callback(*params)
218227

228+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
229+
219230
self.assertIsInstance(fut.exception(), OSError)
220231
if sys.version_info >= (3, 6, 4):
221232
self.assertEqual((10,), self.loop.remove_reader.call_args[0])
@@ -273,8 +284,10 @@ def test_sock_sendall(self):
273284
f = self.loop.create_task(f)
274285
else:
275286
self.assertEqual(type(f).__name__, asyncio.Future.__name__)
287+
288+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
289+
276290
call_args = self.loop._sock_sendall.call_args[0]
277-
assert call_args[0] is f
278291
assert not call_args[1]
279292
assert call_args[2] is sock
280293
assert call_args[3] == b'data'
@@ -288,6 +301,9 @@ def test_sock_sendall_nodata(self):
288301
f = self.loop.create_task(f)
289302
else:
290303
self.assertEqual(type(f).__name__, asyncio.Future.__name__)
304+
305+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
306+
291307
self.assertTrue(f.done())
292308
self.assertIsNone(f.result())
293309
self.assertFalse(self.loop._sock_sendall.called)
@@ -303,6 +319,9 @@ def test_sock_sendall_reconnection(self):
303319
fut = self.loop.sock_sendall(sock, b'data')
304320
if sys.version_info >= (3, 7):
305321
fut = self.loop.create_task(fut)
322+
323+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
324+
306325
callback = self.loop.add_writer.call_args[0][1]
307326
params = self.loop.add_writer.call_args[0][2:]
308327

@@ -312,6 +331,8 @@ def test_sock_sendall_reconnection(self):
312331
sock.send.side_effect = OSError(9)
313332
callback(*params)
314333

334+
self.loop.run_until_complete(asyncio.sleep(0.01, loop=self.loop))
335+
315336
self.assertIsInstance(fut.exception(), OSError)
316337
if sys.version_info >= (3, 6, 4):
317338
self.assertEqual((10,), self.loop.remove_writer.call_args[0])

0 commit comments

Comments
 (0)