signal handling vs. Windows

Author: smurfix

trio_asyncio/base.py

@@ -32,6 +32,7 @@
     _wait_readable = trio.hazmat.wait_socket_readable
     _wait_writable = trio.hazmat.wait_socket_writable
 
+
 class _Clear:
     def clear(self):
         pass
@@ -451,8 +452,8 @@ def _handle_sig(self, sig, _):
     def add_signal_handler(self, sig, callback, *args):
         """asyncio's method to add a signal handler.
         """
-        self._check_signal(sig)
         self._check_closed()
+        self._check_signal(sig)
         if sig == signal.SIGKILL:
             raise RuntimeError("SIGKILL cannot be caught")
         h = Handle(callback, args, self, context=None, is_sync=True)
@@ -464,7 +465,7 @@ def add_signal_handler(self, sig, callback, *args):
     def remove_signal_handler(self, sig):
         """asyncio's method to remove a signal handler.
         """
-        self._check_signal(sig)
+        # self._check_signal(sig)
         try:
             h = self._signal_handlers.pop(sig)
         except KeyError:

trio_asyncio/loop.py

@@ -128,7 +128,7 @@ def set_child_watcher(self, watcher):
         super().set_child_watcher(watcher)
 
 
-class TrioChildWatcher: # (asyncio.AbstractChildWatcher):
+class TrioChildWatcher:  # (asyncio.AbstractChildWatcher):
     # AbstractChildWatcher not available under Windows
     def __init__(self):
         super().__init__()