Accept valid unicode identifiers as class parameter to make_class (#1406)

* Accept valid unicode identifiers as class parameter to make_class

Related to #1404

* Test code style

* Add changelog

---------

Co-authored-by: Hynek Schlawack <hs@ox.cx>

Author: serge-sans-paille

changelog.d/1406.change.md

@@ -0,0 +1 @@
+`attrs.make_class()` now allows for Unicode class names.

src/attr/_make.py

@@ -13,6 +13,7 @@
 import sys
 import types
 import typing
+import unicodedata
 
 from operator import itemgetter
 
@@ -2907,7 +2908,11 @@ def make_class(
     .. versionadded:: 17.1.0 *bases*
     .. versionchanged:: 18.1.0 If *attrs* is ordered, the order is retained.
     .. versionchanged:: 23.2.0 *class_body*
+    .. versionchanged:: 25.2.0 Class names can now be unicode.
     """
+    # Class identifiers are converted into the normal form NFKC while parsing
+    name = unicodedata.normalize("NFKC", name)
+
     if isinstance(attrs, dict):
         cls_dict = attrs
     elif isinstance(attrs, (list, tuple)):

tests/test_make.py

@@ -10,6 +10,7 @@
 import inspect
 import itertools
 import sys
+import unicodedata
 
 from operator import attrgetter
 from typing import Generic, TypeVar
@@ -1100,6 +1101,48 @@ def test_attr_args(self):
 
         assert repr(C(1)).startswith("<tests.test_make.C object at 0x")
 
+    def test_normalized_unicode_attr_args(self):
+        """
+        Unicode identifiers are valid in Python.
+        """
+        clsname = "ü"
+
+        assert clsname == unicodedata.normalize("NFKC", clsname)
+
+        attrname = "ß"
+
+        assert attrname == unicodedata.normalize("NFKC", attrname)
+
+        C = make_class(clsname, [attrname], repr=False)
+
+        assert repr(C(1)).startswith("<tests.test_make.ü object at 0x")
+
+        kwargs = {"ß": 1}
+        c = C(**kwargs)
+
+        assert 1 == c.ß
+
+    def test_unnormalized_unicode_attr_args(self):
+        """
+        Unicode identifiers are normalized to NFKC form in Python.
+        """
+
+        clsname = "Ŀ"
+
+        assert clsname != unicodedata.normalize("NFKC", clsname)
+
+        attrname = "ㅁ"
+
+        assert attrname != unicodedata.normalize("NFKC", attrname)
+
+        C = make_class(clsname, [attrname], repr=False)
+        assert repr(C(1)).startswith("<tests.test_make.L· object at 0x")
+
+        kwargs = {unicodedata.normalize("NFKC", attrname): 1}
+        c = C(**kwargs)
+
+        assert 1 == c.ㅁ
+
     def test_catches_wrong_attrs_type(self):
         """
         Raise `TypeError` if an invalid type for attrs is passed.