Merge pull request #13538 from pytest-dev/patchback/backports/8.4.x/667398f53b7ca9a19a540054b03d505b84379114/pr-13481

[PR #13481/667398f5 backport][8.4.x] testing: Explicitly pass `-Werror` to tests needing it

Author: bluetech

changelog/13480.bugfix.rst

@@ -0,0 +1 @@
+Fixed a few test failures in pytest's own test suite when run with ``-Wdefault`` or a similar override.

testing/test_threadexception.py

@@ -211,7 +211,7 @@ def test_it(request):
         """
     )
 
-    result = pytester.runpytest()
+    result = pytester.runpytest("-Werror")
 
     # TODO: should be a test failure or error
     assert result.ret == pytest.ExitCode.INTERNAL_ERROR

testing/test_warnings.py

@@ -149,6 +149,7 @@ def test_func(fix):
     )
 
 
+@pytest.mark.skip("issue #13485")
 def test_works_with_filterwarnings(pytester: Pytester) -> None:
     """Ensure our warnings capture does not mess with pre-installed filters (#2430)."""
     pytester.makepyfile(