Properly detect fatal errors in Boost.Test

Author: nicoddemus

CHANGELOG.md

@@ -1,3 +1,9 @@
+# 0.4.5
+
+- Properly handle fatal errors in Boost.Test.
+  Thanks @dplucenio for the report.
+
+
 # 0.4.4
 
 - Properly handle fixture failures in Boost.Test.

pytest_cpp/boost.py

@@ -102,6 +102,7 @@ def _parse_log(self, log):
         log_root = ElementTree.fromstring(log)
         parsed_elements.extend(log_root.findall('Exception'))
         parsed_elements.extend(log_root.findall('Error'))
+        parsed_elements.extend(log_root.findall('FatalError'))
 
         result = []
         for elem in parsed_elements:

tests/SConstruct

@@ -20,7 +20,15 @@ Export('env genv')
 
 genv.Program('gtest.cpp')
 
-for filename in ('boost_success.cpp', 'boost_failure.cpp', 'boost_error.cpp', 'boost_fixture_setup_error.cpp'):
+boost_files = [
+    'boost_success.cpp',
+    'boost_failure.cpp',
+    'boost_fatal_error.cpp',
+    'boost_error.cpp',
+    'boost_fixture_setup_error.cpp',
+]
+
+for filename in boost_files:
     env.Program(filename)
 
 SConscript('acceptance/googletest-samples/SConscript')

tests/boost_fatal_error.cpp

@@ -0,0 +1,10 @@
+#include <stdexcept>
+#define BOOST_TEST_MODULE MyTest
+#include <boost/test/included/unit_test.hpp>
+
+
+BOOST_AUTO_TEST_CASE( test_failure_1 )
+{
+    BOOST_REQUIRE( 2 * 3 == 5 );
+}
+

tests/test_pytest_cpp.py

@@ -119,6 +119,17 @@ def test_boost_failure(exes):
     assert fail2.get_file_reference() == ("boost_failure.cpp", 14)
 
 
+def test_boost_fatal_error(exes):
+    facade = BoostTestFacade()
+    failures = facade.run_test(exes.get('boost_fatal_error'), '<unused>')
+    assert len(failures) == 1
+
+    fail1, = failures
+    colors = ('red', 'bold')
+    assert fail1.get_lines() == [('critical check 2 * 3 == 5 failed', colors)]
+    assert fail1.get_file_reference() == ("boost_fatal_error.cpp", 8)
+
+
 def test_boost_error(exes):
     facade = BoostTestFacade()
     failures = facade.run_test(exes.get('boost_error'), '<unused>')