From 42e68a072264504d6af5dd5e6b3eb4dc68bceddf Mon Sep 17 00:00:00 2001 From: Britt Gresham Date: Sat, 12 Dec 2020 13:42:29 -0800 Subject: [PATCH 1/6] Add language to page --- templates/base.jade | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base.jade b/templates/base.jade index ca3f1ce..545670c 100644 --- a/templates/base.jade +++ b/templates/base.jade @@ -1,6 +1,6 @@ doctype html -html +html(lang="en") head title {% block page_title %}PyCascades 2021 – Virtual Edition{% endblock %} From 3ac4543a086519c6372a43e250d25f0ef8f9da8e Mon Sep 17 00:00:00 2001 From: Britt Gresham Date: Sat, 12 Dec 2020 13:42:50 -0800 Subject: [PATCH 2/6] Add AMP SEO block --- templates/base.jade | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/templates/base.jade b/templates/base.jade index 545670c..10cbc56 100644 --- a/templates/base.jade +++ b/templates/base.jade @@ -98,6 +98,20 @@ html(lang="en") var data = {}; pycascades.start(data); + block seo + script(type="application/ld+json"). + { + "@context" : "http://schema.org", + "@type" : "Organization", + "name" : "PyCascades", + "url" : "https://2021.pycascades.com", + "sameAs" : [ + "https://twitter.com/pycascades", + "https://www.instagram.com/pycascades", + "https://www.linkedin.com/company/pycascades" + ] + } + block analytics {% set GOOGLE_ANALYTICS_ID = bag('pycascades.GOOGLE_ANALYTICS_ID') %} {% if envvars('IS_LIVE') and GOOGLE_ANALYTICS_ID %} From dca1f017414c5c4ecc8ee8e711aacaf477551f38 Mon Sep 17 00:00:00 2001 From: Britt Gresham Date: Sat, 12 Dec 2020 13:43:28 -0800 Subject: [PATCH 3/6] Move photo attribution to the bottom left for SEO Currently the action banner overlaps with the attribution on the home page. --- assets/static/_css/pycascades/pycascades.home.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/static/_css/pycascades/pycascades.home.css b/assets/static/_css/pycascades/pycascades.home.css index 15b41ce..a17c9d2 100644 --- a/assets/static/_css/pycascades/pycascades.home.css +++ b/assets/static/_css/pycascades/pycascades.home.css @@ -41,7 +41,7 @@ body.home #intro .main .logo { body.home #intro .image-attribution { position: relative; - top: 1rem; + bottom: 1rem; left: 1rem; font-size: 1.2rem; color: #98D1D6; From b08aa80efaefdbc1d8aa2f5ac0b0e93aa6b7eae1 Mon Sep 17 00:00:00 2001 From: Britt Gresham Date: Sat, 12 Dec 2020 13:51:20 -0800 Subject: [PATCH 4/6] Add accessibility label to newsletter input form --- templates/includes/subscribe.jade | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/templates/includes/subscribe.jade b/templates/includes/subscribe.jade index 13a6c32..bdeba4c 100644 --- a/templates/includes/subscribe.jade +++ b/templates/includes/subscribe.jade @@ -11,13 +11,15 @@ form.subscribe-form( value="", placeholder="Your Email", required="required" + aria-label="Email" ) - button(type="submit") + button(type="submit", aria-label="Subscribe to newsletter") |#[i.fa.fa-send] Subscribe div(style="position: absolute; left: -5000px;", aria-hidden="true") input( type="text", name="b_910a586d174a45ddb1125ad4e_1f87464654", tabindex="-1", - value="" + value="", ) + From 48784f6357fc959aa0409f2578652684e4491141 Mon Sep 17 00:00:00 2001 From: Britt Gresham Date: Sat, 12 Dec 2020 14:32:54 -0800 Subject: [PATCH 5/6] Move attribution to be visible on mobile --- .../_css/pycascades/pycascades.home.css | 35 ++++++++++++------- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/assets/static/_css/pycascades/pycascades.home.css b/assets/static/_css/pycascades/pycascades.home.css index a17c9d2..385a174 100644 --- a/assets/static/_css/pycascades/pycascades.home.css +++ b/assets/static/_css/pycascades/pycascades.home.css @@ -15,6 +15,29 @@ body.home header.headroom--not-top .logo { opacity: 1; } + body.home #intro .image-attribution { + position: absolute; + bottom: 5rem; + right: 3rem; + font-size: 1.2rem; + color: #98D1D6; + text-align: left; + /* Match chevron height */ + margin-bottom: -24px; + } +} + +@media (max-width: 750px) { + body.home #intro .image-attribution { + position: absolute; + top: 7rem; + right: 1rem; + font-size: 1.2rem; + color: #98D1D6; + text-align: left; + /* Match chevron height */ + margin-bottom: -24px; + } } body.home header nav > ul > li.home { @@ -39,18 +62,6 @@ body.home #intro .main .logo { } } -body.home #intro .image-attribution { - position: relative; - bottom: 1rem; - left: 1rem; - font-size: 1.2rem; - color: #98D1D6; - text-align: left; - left: 1rem; - /* Match chevron height */ - margin-bottom: -24px; -} - body.home #intro .image-attribution a { color: #98D1D6; text-decoration: none; From 4a11ea48beedd6eb871ff412eb00bf7f18df11be Mon Sep 17 00:00:00 2001 From: Britt Gresham Date: Sat, 12 Dec 2020 14:59:52 -0800 Subject: [PATCH 6/6] Do not add referrers to external links --- templates/base.jade | 8 ++++---- templates/home.jade | 8 +++++--- templates/includes/nav.jade | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/templates/base.jade b/templates/base.jade index 10cbc56..a7fded3 100644 --- a/templates/base.jade +++ b/templates/base.jade @@ -58,7 +58,7 @@ html(lang="en") block main #banner - a(href="https://pretix.eu/pycascades/remote-2021/" target="_blank") + a(href="https://pretix.eu/pycascades/remote-2021/" target="_blank" rel="noreferrer") strong Tickets available! footer @@ -67,13 +67,13 @@ html(lang="en") li a(href="{{ '/code-of-conduct'|url }}") Code of Conduct li.slack - a(href="{{ bag('pycascades.SLACK_URL') }}", target="_blank") + a(href="{{ bag('pycascades.SLACK_URL') }}", target="_blank" rel="noreferrer") |#[i.fa.fa-slack] PyCascades li.twitter - a(href="{{ bag('pycascades.TWITTER_URL') }}", target="_blank") + a(href="{{ bag('pycascades.TWITTER_URL') }}", target="_blank" rel="noreferrer") |#[i.fa.fa-twitter] PyCascades li.instagram - a(href="{{ bag('pycascades.INSTAGRAM_URL') }}", target="_blank") + a(href="{{ bag('pycascades.INSTAGRAM_URL') }}", target="_blank" rel="noreferrer") |#[i.fa.fa-instagram] PyCascades block logos diff --git a/templates/home.jade b/templates/home.jade index 6bf969e..9146ca8 100644 --- a/templates/home.jade +++ b/templates/home.jade @@ -9,7 +9,7 @@ block main .background(du-parallax, y="animator") .image.bg-cover(ff-bg="static/backgrounds/online.jpg") .image-attribution - | Header photo © #[a(href="https://thea.codes") Alethea Flowers] / CC BY-SA 4.0 + | Header photo © #[a(href="https://thea.codes", rel="noreferrer") Alethea Flowers] / CC BY-SA 4.0 .overlay .main.vcontainer .inner @@ -65,7 +65,8 @@ block main .one-half.column.social a( href="{{ bag('pycascades.TWITTER_URL') }}", - target="_blank" + target="_blank", + rel="noreferrer" ). #[i.fa.fa-2x.fa-twitter] | You can also follow us. @@ -73,7 +74,8 @@ block main .one-half.column.social a( href="{{ bag('pycascades.SLACK_URL') }}", - target="_blank" + target="_blank", + rel="noreferrer" ). #[i.fa.fa-2x.fa-slack] diff --git a/templates/includes/nav.jade b/templates/includes/nav.jade index 458d3e3..7f13374 100644 --- a/templates/includes/nav.jade +++ b/templates/includes/nav.jade @@ -48,7 +48,7 @@ nav //- a(href="{{ '/sponsors'|url }}") Our Sponsors li.attend - a(href="https://pretix.eu/pycascades/remote-2021/", target="_blank") Tickets + a(href="https://pretix.eu/pycascades/remote-2021/", target="_blank", rel="noreferrer") Tickets li.news a(href="{{ '/news'|url }}") News