Question about grouped parameter models for SPM and SPMe

[oarcelus]

Hello, I am lookin at the grouped parameter model examples provided in PyBOB, for both SPM and SPMe models. I have a question about the definition of the evaluation of grouped parameters through the default parameters in Chen2020 set. In this dataset electrolyte diffusivity and conductivity are functions of c_e and T. However in GroupedSPMe they are defined as Parameter instead of FunctionParameter, this is because the default_parameter_values method evaluates these parameters around c_e0 and T0 and gives a single Scalar value as a parameter.

I wonder how would you go around if you would like to group these parameters keeping the original concentration and temperature dependencies of Chen2020 parameter dataset. I guess defining tau_e_ as a FunctionParameter is a step but not sure if the callable De can be assigned like that, given that the arguments of both functions will be different, one being c_e/c_e_max and the other c_e

[NicolaCourtier]

Hi @oarcelus

You are thinking along the right lines. You'd need to change the grouped parameter into a FunctionParameter of appropriate variables within the model. Then define your function as shown in this example.