Fix CmdCallback_P strings comparison

neomilium · neomilium · commit b48f403dbc26 · 2017-06-14T10:20:58.000+02:00
According to documentation, strcasecmp_P takes first SRAM string then Flash string
diff --git a/src/CmdCallback.hpp b/src/CmdCallback.hpp
@@ -172,12 +172,12 @@ template <size_t STORESIZE>
 class CmdCallback_P : public _CmdCallback<STORESIZE, CmdParserString_P>
 {
     /**
-     * @implement CmdCallbackObject with strcmp_P
+     * @implement CmdCallbackObject with strcasecmp_P
      */
     virtual bool equalStoreCmd(size_t idx, char *cmdStr)
     {
         if (this->checkStorePos(idx) &&
-            strcasecmp_P(this->m_cmdList[idx], cmdStr) == 0) {
+            strcasecmp_P(cmdStr, this->m_cmdList[idx]) == 0) {
             return true;
         }
 
@@ -195,7 +195,7 @@ template <size_t STORESIZE>
 class CmdCallback : public _CmdCallback<STORESIZE, CmdParserString>
 {
     /**
-     * @implement CmdCallbackObject with strcmp_P
+     * @implement CmdCallbackObject with strcasecmp
      */
     virtual bool equalStoreCmd(size_t idx, char *cmdStr)
     {

Original file line number	Diff line number	Diff line change
`@@ -172,12 +172,12 @@ template <size_t STORESIZE>`
`172`	`172`	`class CmdCallback_P : public _CmdCallback<STORESIZE, CmdParserString_P>`
`173`	`173`	`{`
`174`	`174`	`/**`
`175`		`- * @implement CmdCallbackObject with strcmp_P`
	`175`	`+ * @implement CmdCallbackObject with strcasecmp_P`
`176`	`176`	`*/`
`177`	`177`	`virtual bool equalStoreCmd(size_t idx, char *cmdStr)`
`178`	`178`	`{`
`179`	`179`	`if (this->checkStorePos(idx) &&`
`180`		`- strcasecmp_P(this->m_cmdList[idx], cmdStr) == 0) {`
	`180`	`+ strcasecmp_P(cmdStr, this->m_cmdList[idx]) == 0) {`
`181`	`181`	`return true;`
`182`	`182`	`}`
`183`	`183`
`@@ -195,7 +195,7 @@ template <size_t STORESIZE>`
`195`	`195`	`class CmdCallback : public _CmdCallback<STORESIZE, CmdParserString>`
`196`	`196`	`{`
`197`	`197`	`/**`
`198`		`- * @implement CmdCallbackObject with strcmp_P`
	`198`	`+ * @implement CmdCallbackObject with strcasecmp`
`199`	`199`	`*/`
`200`	`200`	`virtual bool equalStoreCmd(size_t idx, char *cmdStr)`
`201`	`201`	`{`