From af8f86c6289256782478237f76cd7c776e12ba45 Mon Sep 17 00:00:00 2001 From: Mahima Singh Date: Thu, 1 Oct 2026 09:42:23 +0530 Subject: [PATCH] P4DEVOPS-16202: fix Reloader annotation to use templated pools ConfigMap name deployment-api.yaml and deployment-manager.yaml hardcoded the literal string "vmpooler-pools" as the second configmap.reloader.stakater.com/reload target instead of templating .Values.poolsConfigMapName. Consumers that override poolsConfigMapName (e.g. dio-helm-charts' dio-vmpooler chart sets it to "dio-vmpooler-pools") never get picked up by Reloader, so pool config changes silently require a manual rollout restart. Confirmed via `helm template --set poolsConfigMapName=dio-vmpooler-pools`: the annotation now renders "vmpooler-baseconfig,dio-vmpooler-pools" instead of "vmpooler-baseconfig,vmpooler-pools". Co-Authored-By: Claude Sonnet 5 --- helm-charts/vmpooler/Chart.yaml | 2 +- helm-charts/vmpooler/templates/deployment-api.yaml | 2 +- helm-charts/vmpooler/templates/deployment-manager.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/helm-charts/vmpooler/Chart.yaml b/helm-charts/vmpooler/Chart.yaml index 6907109..8140f2a 100644 --- a/helm-charts/vmpooler/Chart.yaml +++ b/helm-charts/vmpooler/Chart.yaml @@ -3,7 +3,7 @@ name: vmpooler description: A Helm chart to deploy vmpooler type: application icon: https://github.com/puppetlabs/vmpooler/raw/master/lib/vmpooler/public/img/logo.png -version: 3.10.3 +version: 3.10.4 appVersion: pr177-9010ad15d1b63bae44be352e7288a477bf6f667d dependencies: - name: redis diff --git a/helm-charts/vmpooler/templates/deployment-api.yaml b/helm-charts/vmpooler/templates/deployment-api.yaml index f89bec8..3b27289 100644 --- a/helm-charts/vmpooler/templates/deployment-api.yaml +++ b/helm-charts/vmpooler/templates/deployment-api.yaml @@ -9,7 +9,7 @@ metadata: {{- include "vmpooler.labels" . | nindent 4 }} test: liveness annotations: - configmap.reloader.stakater.com/reload: "{{ .Values.configmapName }},vmpooler-pools" + configmap.reloader.stakater.com/reload: "{{ .Values.configmapName }},{{ .Values.poolsConfigMapName }}" secret.reloader.stakater.com/reload: 'redis' spec: replicas: {{ .Values.api.replicaCount }} diff --git a/helm-charts/vmpooler/templates/deployment-manager.yaml b/helm-charts/vmpooler/templates/deployment-manager.yaml index 63bda8f..a834e39 100644 --- a/helm-charts/vmpooler/templates/deployment-manager.yaml +++ b/helm-charts/vmpooler/templates/deployment-manager.yaml @@ -9,7 +9,7 @@ metadata: {{- include "vmpooler.labels" . | nindent 4 }} test: liveness annotations: - configmap.reloader.stakater.com/reload: "{{ .Values.configmapName }},vmpooler-pools" + configmap.reloader.stakater.com/reload: "{{ .Values.configmapName }},{{ .Values.poolsConfigMapName }}" secret.reloader.stakater.com/reload: 'redis' spec: replicas: 1