Why
The .github/skills tree carried from the hub in #940 brings dotnet-codestyle/references/testing.md, which states:
Native xUnit asserts (Assert.Equal, Assert.True, ...) are not allowed, use the fluent .Should() API.
Most of the suite already follows it. Four files do not, and they predate the convention arriving here, so this is a conformance gap the carry surfaced rather than anything #940 changed. All four are line-endings-only in that pull request.
What
53 native assertions remain:
| File |
Count |
PlexCleanerTests/ConfigFileTests.cs |
23 |
PlexCleanerTests/SidecarFileTests.cs |
19 |
PlexCleanerTests/VersionParsingTests.cs |
10 |
PlexCleanerTests/WildcardTests.cs |
1 |
By form: Assert.Equal 27, Assert.True 12, Assert.Contains 7, Assert.NotNull 6, Assert.Empty 1.
Assert.Skip and Assert.SkipWhen stay native per the same reference, since dynamic skipping is control flow rather than an assertion. The suite currently uses neither.
Notes
Raised by Copilot against #940 as a body-only finding ("At least one updated test still uses native xUnit assertions despite the newly carried .NET testing convention requiring AwesomeAssertions"). Deferred out of that pull request rather than folded in: the rewrite touches four files and none of the resync's own subject matter, and #940 was already green and fully reviewed at the time.
AwesomeAssertions is already referenced by the test project, so this needs no dependency change.
Why
The
.github/skillstree carried from the hub in #940 bringsdotnet-codestyle/references/testing.md, which states:Most of the suite already follows it. Four files do not, and they predate the convention arriving here, so this is a conformance gap the carry surfaced rather than anything #940 changed. All four are line-endings-only in that pull request.
What
53 native assertions remain:
PlexCleanerTests/ConfigFileTests.csPlexCleanerTests/SidecarFileTests.csPlexCleanerTests/VersionParsingTests.csPlexCleanerTests/WildcardTests.csBy form:
Assert.Equal27,Assert.True12,Assert.Contains7,Assert.NotNull6,Assert.Empty1.Assert.SkipandAssert.SkipWhenstay native per the same reference, since dynamic skipping is control flow rather than an assertion. The suite currently uses neither.Notes
Raised by Copilot against #940 as a body-only finding ("At least one updated test still uses native xUnit assertions despite the newly carried .NET testing convention requiring AwesomeAssertions"). Deferred out of that pull request rather than folded in: the rewrite touches four files and none of the resync's own subject matter, and #940 was already green and fully reviewed at the time.
AwesomeAssertions is already referenced by the test project, so this needs no dependency change.