signup dev same as prod

Author: Nixxx19

client/modules/User/actions.ts

@@ -92,7 +92,11 @@ export function validateAndLoginUser(formProps: {
               })
             );
             dispatch(justOpenedProject());
-            browserHistory.push(previousPath);
+            const path =
+              previousPath === '/signup' || previousPath === '/login'
+                ? '/'
+                : previousPath;
+            browserHistory.push(path);
             resolve();
           })
           .catch((error) =>
@@ -123,7 +127,11 @@ export function validateAndSignUpUser(formValues: CreateUserRequestBody) {
         .then((response) => {
           dispatch(authenticateUser(response.data));
           dispatch(justOpenedProject());
-          browserHistory.push(previousPath);
+          const path =
+            previousPath === '/signup' || previousPath === '/login'
+              ? '/'
+              : previousPath;
+          browserHistory.push(path);
           resolve();
         })
         .catch((error) => {

server/controllers/user.controller/signup.ts

@@ -71,7 +71,13 @@ export const createUser: RequestHandler<
         res.json(userResponse(user));
       } catch (mailErr) {
         console.error(mailErr);
-        res.status(500).json({ error: 'Failed to send verification email.' });
+        // In development, still return success so signup UX matches production
+        // (redirect to home, user logged in). Email may be unconfigured locally.
+        if (process.env.NODE_ENV !== 'production') {
+          res.json(userResponse(user));
+        } else {
+          res.status(500).json({ error: 'Failed to send verification email.' });
+        }
       }
     });
   } catch (err) {