Skip to content

Commit a7f5592

Browse files
authored
Merge pull request #3889 from Nixxx19/fix/mass-assignment-vulnerability-3876
fix: prevent mass-assignment of user field in createProject and apiCreateProject #3876
2 parents 5d60266 + 14b6873 commit a7f5592

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

server/controllers/project.controller/createProject.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@ import {
66
} from '../../domain-objects/Project';
77

88
export default function createProject(req, res) {
9-
let projectValues = {
10-
user: req.user._id
11-
};
12-
13-
projectValues = Object.assign(projectValues, req.body);
9+
const projectValues = Object.assign({}, req.body, { user: req.user._id });
1410

1511
function sendFailure(err) {
1612
res.status(400).json({ success: false });
@@ -32,7 +28,7 @@ export default function createProject(req, res) {
3228

3329
// TODO: What happens if you don't supply any files?
3430
export async function apiCreateProject(req, res) {
35-
const params = Object.assign({ user: req.user._id }, req.body);
31+
const params = Object.assign({}, req.body, { user: req.user._id });
3632

3733
const sendValidationErrors = (err, type, code = 422) => {
3834
res.status(code).json({

0 commit comments

Comments
 (0)