Merge pull request #3932 from SinhaS12/fix/User-Model

Fix fragile arguments.length check in findByEmailOrUsername

Author: raclim

client/modules/User/components/AccountForm.tsx

@@ -148,7 +148,7 @@ export function AccountForm() {
             <Field name="currentPassword">
               {(field) => (
                 <p className="form__field">
-                  <label htmlFor="current password" className="form__label">
+                  <label htmlFor="currentPassword" className="form__label">
                     {t('AccountForm.CurrentPassword')}
                   </label>
                   <input
@@ -172,7 +172,7 @@ export function AccountForm() {
             <Field name="newPassword">
               {(field) => (
                 <p className="form__field">
-                  <label htmlFor="new password" className="form__label">
+                  <label htmlFor="newPassword" className="form__label">
                     {t('AccountForm.NewPassword')}
                   </label>
                   <input

server/models/user.ts

@@ -287,11 +287,7 @@ userSchema.statics.findByEmailOrUsername = async function findByEmailOrUsername(
     : value.indexOf('@') > -1;
 
   // do the case insensitive stuff
-  if (
-    arguments.length === 2 &&
-    typeof options === 'object' &&
-    options.caseInsensitive
-  ) {
+  if (options?.caseInsensitive) {
     const query = isEmail ? { email: value } : { username: value };
     const foundUser = await user
       .findOne(query)