fix: change test for 500 error responses

Author: kitlord

server/controllers/user.controller/__tests__/authManagement/updateSettings.test.ts

@@ -523,7 +523,7 @@ describe('user.controller > auth management > updateSettings (email, username, p
 
   describe('and when there is any other error', () => {
     beforeEach(async () => {
-      User.findById = jest.fn().mockRejectedValue('db error');
+      User.findById = jest.fn().mockRejectedValue('Internal server error');
       requestBody = minimumValidRequest;
       request.setBody(requestBody);
       await updateSettings(
@@ -534,7 +534,9 @@ describe('user.controller > auth management > updateSettings (email, username, p
     });
     it('returns a 500 error', () => {
       expect(response.status).toHaveBeenCalledWith(500);
-      expect(response.json).toHaveBeenCalledWith({ error: 'db error' });
+      expect(response.json).toHaveBeenCalledWith({
+        error: 'Internal server error'
+      });
     });
   });
 });

server/controllers/user.controller/__tests__/helpers.test.ts

@@ -87,7 +87,7 @@ describe('user.controller > helpers', () => {
       );
       expect(response.status).toHaveBeenCalledWith(500);
       expect(response.json).toHaveBeenCalledWith({
-        error: 'async error'
+        error: 'Internal server error'
       });
     });
   });

server/controllers/user.controller/__tests__/userPreferences.test.ts

@@ -84,7 +84,7 @@ describe('user.controller > user preferences', () => {
     it('returns 500 if saving preferences fails', async () => {
       mockUser = createMockUser({
         preferences: { ...mockUserPreferences, theme: AppThemeOptions.LIGHT },
-        save: jest.fn().mockRejectedValue(new Error('DB error'))
+        save: jest.fn().mockRejectedValue(new Error('Internal server error'))
       });
 
       User.findById = jest
@@ -101,7 +101,9 @@ describe('user.controller > user preferences', () => {
       );
 
       expect(response.status).toHaveBeenCalledWith(500);
-      expect(response.json).toHaveBeenCalledWith({ error: expect.any(Error) });
+      expect(response.json).toHaveBeenCalledWith({
+        error: 'Internal server error'
+      });
     });
   });
 
@@ -155,7 +157,7 @@ describe('user.controller > user preferences', () => {
     it('returns 500 if saving cookieConsent fails', async () => {
       mockUser = createMockUser({
         cookieConsent: CookieConsentOptions.ALL,
-        save: jest.fn().mockRejectedValue(new Error('DB error'))
+        save: jest.fn().mockRejectedValue(new Error('Internal server error'))
       });
 
       User.findById = jest
@@ -172,7 +174,9 @@ describe('user.controller > user preferences', () => {
       );
 
       expect(response.status).toHaveBeenCalledWith(500);
-      expect(response.json).toHaveBeenCalledWith({ error: expect.any(Error) });
+      expect(response.json).toHaveBeenCalledWith({
+        error: 'Internal server error'
+      });
     });
   });
 });