Skip to content

Commit 7cd2cae

Browse files
authored
Merge pull request #3920 from Jatin24062005/Visibility_Map_Function_Error_Fix
FIxing Visibility Updating Bug
2 parents 6d76b33 + 0fa015b commit 7cd2cae

2 files changed

Lines changed: 13 additions & 8 deletions

File tree

client/modules/IDE/actions/project.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -420,12 +420,12 @@ export function changeVisibility(projectId, projectName, visibility, t) {
420420
.patch('/project/visibility', { projectId, visibility })
421421
.then((response) => {
422422
if (response.status === 200) {
423-
const { visibility: newVisibility, updatedAt } = response.data;
423+
const { visibility: newVisibility, updatedAt, id } = response.data;
424424

425425
dispatch({
426426
type: ActionTypes.CHANGE_VISIBILITY,
427427
payload: {
428-
id: response.data.id,
428+
id,
429429
visibility: newVisibility
430430
}
431431
});

client/modules/IDE/reducers/projects.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,18 @@ const sketches = (state = [], action) => {
77
case ActionTypes.DELETE_PROJECT:
88
return state.projects.filter((sketch) => sketch.id !== action.id);
99
case ActionTypes.CHANGE_VISIBILITY: {
10-
return state.map((sketch) => {
11-
if (sketch.id === action.payload.id) {
12-
return { ...sketch, visibility: action.payload.visibility };
13-
}
14-
return sketch;
15-
});
10+
const updatedProjects = state.projects.map((sketch) =>
11+
sketch.id === action.payload.id
12+
? { ...sketch, visibility: action.payload.visibility }
13+
: sketch
14+
);
15+
16+
return {
17+
...state,
18+
projects: updatedProjects
19+
};
1620
}
21+
1722
case ActionTypes.RENAME_PROJECT: {
1823
return state.map((sketch) => {
1924
if (sketch.id === action.payload.id) {

0 commit comments

Comments
 (0)