address review feedback

- Add JSDoc to parseUrlParams
- Remove export from p5VersionStrings and copy its logic to test file
- Fix invalid version test to use 'invalid-version' instead of '9.9.9'

Author: Hugo-RM

client/utils/parseURLParams.test.ts

@@ -1,5 +1,13 @@
-import { parseUrlParams, p5VersionStrings } from './parseURLParams';
-import { currentP5Version } from '../../common/p5Versions';
+import { parseUrlParams } from './parseURLParams';
+import { p5Versions, currentP5Version } from '../../common/p5Versions';
+
+function getVersionString(
+  item: string | { version: string; label: string }
+): string {
+  return typeof item === 'string' ? item : item.version;
+}
+
+const p5VersionStrings = p5Versions.map(getVersionString);
 
 describe('parseUrlParams', () => {
   describe('default behavior', () => {
@@ -39,7 +47,7 @@ describe('parseUrlParams', () => {
       const good = parseUrlParams('https://example.com?version=1.4.0');
       expect(good.version).toBe('1.4.0');
 
-      const bad = parseUrlParams('https://example.com?version=9.9.9');
+      const bad = parseUrlParams('https://example.com?version=invalid-version');
       expect(bad.version).toBe(currentP5Version);
     });
 

client/utils/parseURLParams.ts

@@ -21,7 +21,7 @@ function getVersionString(
   return typeof item === 'string' ? item : item.version;
 }
 
-export const p5VersionStrings = p5Versions.map(getVersionString);
+const p5VersionStrings = p5Versions.map(getVersionString);
 
 function getNewestVersion(versions: string[]): string {
   return versions.sort((a, b) => {
@@ -83,6 +83,12 @@ function validateBool(value: string | null, defaultValue: boolean): boolean {
   return defaultValue;
 }
 
+/**
+ * Parses URL parameters for version and boolean flags.
+ *
+ * @param url - The URL string to parse.
+ * @returns Parsed and validated URL parameters including version and library flags.
+ */
 export function parseUrlParams(url: string): ParsedUrlParams {
   const params = new URLSearchParams(
     new URL(url, 'https://dummy.origin').search