test: Make property tests enforce witnessed outcomes

Author: zharinov

crates/plotnik-lib/src/compiler/fmt/format_tests.rs

@@ -1,7 +1,7 @@
 use indoc::indoc;
 
 use super::format::{FormatError, format_query, format_query_measured, format_query_with_config};
-use crate::compiler::diagnostics::Error;
+use crate::compiler::diagnostics::{DiagnosticKind, Error};
 use crate::compiler::parse::ParseConfig;
 
 #[test]
@@ -433,6 +433,19 @@ fn rejects_parse_errors_and_propagates_limits() {
     ));
 }
 
+#[test]
+fn rejects_recovered_group_without_closer() {
+    let error = format_query("((\"(\"").expect_err("unclosed nested group is rejected");
+    let diagnostics = error.diagnostics().expect("syntax failure has diagnostics");
+
+    assert_eq!(diagnostics.error_count(), 1);
+    assert!(
+        diagnostics
+            .kinds()
+            .any(|kind| kind == DiagnosticKind::UnclosedTree)
+    );
+}
+
 #[test]
 fn parse_errors_include_their_rendering_source_map() {
     let error = format_query("Q = (").expect_err("broken query is rejected");

crates/plotnik-lib/src/compiler/parse/parser.rs

@@ -410,10 +410,11 @@ impl<'q, 'd> Parser<'q, 'd> {
         // Use full range for easier downstream error suppression
         let full_range = TextRange::new(open.span.start(), current.end());
         let source_id = self.source_id;
-        let Some(report) = self.report_at(kind, full_range) else {
-            return;
-        };
-        report
+        // The opener may already own a warning (legacy sequence syntax). Report
+        // past start-offset dedup so that warning cannot suppress this gating error.
+        self.diagnostics
+            .report(kind, Span::new(source_id, full_range))
+            .suppression_range(full_range)
             .related_to(
                 Span::new(source_id, open.span),
                 format!("{construct} started here"),

crates/plotnik-lib/src/compiler/parse/parser_tests.rs

@@ -1,5 +1,21 @@
+use crate::compiler::DiagnosticKind;
 use crate::compiler::query::QueryBuilder;
 
+#[test]
+fn unclosed_legacy_sequence_is_an_error() {
+    let query = QueryBuilder::from_inline("((\"(\"")
+        .analyze()
+        .expect("query parsing stays within resource limits");
+
+    assert!(!query.is_valid());
+    assert!(
+        query
+            .diagnostics()
+            .kinds()
+            .any(|kind| kind == DiagnosticKind::UnclosedTree)
+    );
+}
+
 #[test]
 fn deeply_nested_trees_hit_recursion_limit() {
     let depth = 128;

crates/plotnik-tests/Cargo.toml

@@ -22,7 +22,7 @@ arborium-dart = "2.18.0"
 arborium-javascript = "2.18.0"
 arborium-typescript = "2.18.0"
 serde = { version = "1.0", features = ["derive"] }
-serde_json = "=1.0.150"
+serde_json = { version = "=1.0.150", features = ["unbounded_depth"] }
 tree-sitter = "=0.26.10"
 
 [dev-dependencies]