Update to Webpack 5 🎉

But got a deprecation warning:

> BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.

Author: pirelenito

package.json

@@ -50,12 +50,13 @@
   "devDependencies": {
     "@size-limit/preset-small-lib": "^4.10.2",
     "@types/fs-extra": "^9.0.11",
-    "@types/webpack": "4.41.27",
+    "@types/webpack": "5.28.0",
+    "file-loader": "^6.2.0",
     "fs-extra": "^9.1.0",
     "size-limit": "^4.10.2",
     "tsdx": "^0.14.1",
     "tslib": "^2.2.0",
     "typescript": "^4.2.4",
-    "webpack": "^4.1.1"
+    "webpack": "^5.28.0"
   }
 }

src/build-file.ts

@@ -10,7 +10,7 @@ interface BuildFileOptions {
 }
 
 export default function buildFile({ compiler, gitWorkTree, command, replacePattern, asset }: BuildFileOptions) {
-  let data: string | undefined = ''
+  let data: string = ''
 
   compiler.hooks.compilation.tap('GitRevisionWebpackPlugin', compilation => {
     compilation.hooks.optimizeTree.tapAsync('optimize-tree', (_, __, callback) => {
@@ -24,12 +24,7 @@ export default function buildFile({ compiler, gitWorkTree, command, replacePatte
       })
     })
 
-    // we are missing the type definition for assetPath
-    // TODO: create a PR to DefinitelyTyped
-    const mainTemplate = compilation.mainTemplate as any
-
-    // TODO remove `any` once we get the type definitions
-    mainTemplate.hooks.assetPath.tap('GitRevisionWebpackPlugin', (assetPath: any, chunkData: any) => {
+    compilation.hooks.assetPath.tap('GitRevisionWebpackPlugin', (assetPath: any, chunkData: any) => {
       const path = typeof assetPath === 'function' ? assetPath(chunkData) : assetPath
 
       if (!data) return path
@@ -45,6 +40,16 @@ export default function buildFile({ compiler, gitWorkTree, command, replacePatte
       size: function() {
         return data ? data.length : 0
       },
+      buffer: function() {
+        return Buffer.from(data)
+      },
+      map: function() {
+        return {}
+      },
+      sourceAndMap: function() {
+        return { source: data, map: {} }
+      },
+      updateHash: function() {},
     }
   })
 }

src/helpers/run-git-command.ts

@@ -4,7 +4,7 @@ import path from 'path'
 import removeEmptyLines from './remove-empty-lines'
 
 interface Cb {
-  (err: Error | null, output?: string): void
+  (err: Error | null, output: string): void
 }
 
 export default function(gitWorkTree: string | undefined, command: string, callback?: Cb) {
@@ -15,7 +15,7 @@ export default function(gitWorkTree: string | undefined, command: string, callba
   if (callback) {
     exec(gitCommand, function(err, stdout) {
       if (err) {
-        return callback(err)
+        return callback(err, '')
       }
       callback(null, removeEmptyLines(stdout))
     })

test/integration.spec.ts

@@ -13,7 +13,7 @@ const targetGitRepository = path.join(__dirname, '../tmp/project/.git')
 const targetBuild = path.join(__dirname, '../tmp/build')
 
 describe('git-revision-webpack-plugin default', function() {
-  beforeEach(function(done) {
+  beforeAll(function(done) {
     fs.emptyDirSync(targetProject)
     fs.copySync(sourceProject, targetProject)
 
@@ -95,7 +95,7 @@ describe('git-revision-webpack-plugin default', function() {
 })
 
 describe('git-revision-webpack-plugin with lightweightTags option', function() {
-  beforeEach(function(done) {
+  beforeAll(function(done) {
     fs.emptyDirSync(targetProject)
     fs.copySync(sourceProject, targetProject)
 
@@ -153,7 +153,7 @@ describe('git-revision-webpack-plugin with lightweightTags option', function() {
       const mainJs = fs.readFileSync(versionPath, 'utf8')
 
       const expectedPublicPath =
-        'r.p="http://cdn.com/assets/master/v2.0.0-beta/9a15b3ba1f8c347f9db94bcfde9630ed4fdeb1b2"'
+        'o.p="http://cdn.com/assets/master/v2.0.0-beta/9a15b3ba1f8c347f9db94bcfde9630ed4fdeb1b2"'
 
       expect(mainJs.indexOf(expectedPublicPath) !== -1).toEqual(true)
     })
@@ -178,7 +178,7 @@ describe('git-revision-webpack-plugin with lightweightTags option', function() {
 })
 
 describe('git-revision-webpack-plugin without branch option', function() {
-  beforeEach(function(done) {
+  beforeAll(function(done) {
     fs.emptyDirSync(targetProject)
     fs.copySync(sourceProject, targetProject)