Refactor lightweight tags to remove duplication 🐞

Author: pirelenito

lib/index.js

@@ -5,10 +5,15 @@ var COMMITHASH_COMMAND = 'rev-parse HEAD'
 var VERSION_COMMAND = 'describe --always'
 
 function GitRevisionPlugin (options) {
-  this.gitWorkTree = options && options.gitWorkTree
-  this.lightweightTags = options && options.lightweightTags || false
-  this.commithashCommand = options && options.commithashCommand || COMMITHASH_COMMAND
-  this.versionCommand = options && options.versionCommand || VERSION_COMMAND
+  options = options || {}
+
+  this.gitWorkTree = options.gitWorkTree
+
+  this.commithashCommand = options.commithashCommand ||
+    COMMITHASH_COMMAND
+
+  this.versionCommand = options.versionCommand ||
+    VERSION_COMMAND + (options.lightweightTags ? ' --tags' : '')
 }
 
 GitRevisionPlugin.prototype.apply = function (compiler) {
@@ -21,7 +26,7 @@ GitRevisionPlugin.prototype.apply = function (compiler) {
 
   buildFile(compiler,
     this.gitWorkTree,
-    this.versionCommand + (this.lightweightTags ? ' --tags' : ''),
+    this.versionCommand,
     /\[git-revision-version\]/gi,
     'VERSION'
   )
@@ -37,7 +42,7 @@ GitRevisionPlugin.prototype.commithash = function () {
 GitRevisionPlugin.prototype.version = function () {
   return runGitCommand(
     this.gitWorkTree,
-    this.versionCommand + (this.lightweightTags ? ' --tags' : '')
+    this.versionCommand
   )
 }