Merge pull request #30 from pirelenito/node-compatibility

Match wepack's engine definitions for Node compatibility

Author: pirelenito

.travis.yml

@@ -1,5 +1,6 @@
 language: node_js
 node_js:
+  - "6.11.5"
   - "8"
   - "9"
 # send builds to the container-based infrastructure

lib/build-file.js

@@ -1,6 +1,6 @@
 var runGitCommand = require('./helpers/run-git-command')
 
-module.exports = function buildFile (compiler, gitWorkTree, command, replacePattern, asset) {
+module.exports = ({ compiler, gitWorkTree, command, replacePattern, asset }) => {
   var data = ''
 
   compiler.hooks.compilation.tap('compilation', (compilation) => {

lib/index.js

@@ -27,30 +27,30 @@ function GitRevisionPlugin (options) {
 }
 
 GitRevisionPlugin.prototype.apply = function (compiler) {
-  buildFile(
-    compiler,
-    this.gitWorkTree,
-    this.commithashCommand,
-    /\[git-revision-hash\]/gi,
-    'COMMITHASH'
-  )
+  buildFile({
+    compiler: compiler,
+    gitWorkTree: this.gitWorkTree,
+    command: this.commithashCommand,
+    replacePattern: /\[git-revision-hash\]/gi,
+    asset: 'COMMITHASH'
+  })
 
-  buildFile(
-    compiler,
-    this.gitWorkTree,
-    this.versionCommand,
-    /\[git-revision-version\]/gi,
-    'VERSION'
-  )
+  buildFile({
+    compiler: compiler,
+    gitWorkTree: this.gitWorkTree,
+    command: this.versionCommand,
+    replacePattern: /\[git-revision-version\]/gi,
+    asset: 'VERSION'
+  })
 
   if (this.createBranchFile) {
-    buildFile(
-      compiler,
-      this.gitWorkTree,
-      this.branchCommand,
-      /\[git-revision-branch\]/gi,
-      'BRANCH'
-    )
+    buildFile({
+      compiler: compiler,
+      gitWorkTree: this.gitWorkTree,
+      command: this.branchCommand,
+      replacePattern: /\[git-revision-branch\]/gi,
+      asset: 'BRANCH'
+    })
   }
 }
 

lib/index.spec.js

@@ -17,10 +17,10 @@ describe('git-revision-webpack-plugin (unit)', function () {
       }).apply()
 
       var commithashCall = buildFile.args.find(function (calls) {
-        return calls[4] === 'COMMITHASH'
+        return calls[0].asset === 'COMMITHASH'
       })
 
-      expect(commithashCall[2]).to.eql('custom commithash command')
+      expect(commithashCall[0].command).to.eql('custom commithash command')
     })
 
     it('should run the custom git command on .commithash', function () {
@@ -55,10 +55,10 @@ describe('git-revision-webpack-plugin (unit)', function () {
       }).apply()
 
       var commithashCall = buildFile.args.find(function (calls) {
-        return calls[4] === 'VERSION'
+        return calls[0].asset === 'VERSION'
       })
 
-      expect(commithashCall[2]).to.eql('custom version command')
+      expect(commithashCall[0].command).to.eql('custom version command')
     })
 
     it('should run the custom git command on .version', function () {
@@ -84,10 +84,10 @@ describe('git-revision-webpack-plugin (unit)', function () {
       }).apply()
 
       var branchCall = buildFile.args.find(function (calls) {
-        return calls[4] === 'BRANCH'
+        return calls[0].asset === 'BRANCH'
       })
 
-      expect(branchCall[2]).to.eql('custom branch command')
+      expect(branchCall[0].command).to.eql('custom branch command')
     })
 
     it('should run the custom git command on .version', function () {

package.json

@@ -10,8 +10,7 @@
     "test:unit-watch": "npm run test:unit -- --watch"
   },
   "engines": {
-    "node": ">=8.0.0",
-    "npm": ">=5.0.0"
+    "node": ">=6.11.5"
   },
   "files": [
     "lib"