From dc86824274d104f5b36c7acbcc931eb8bba661b6 Mon Sep 17 00:00:00 2001 From: Victor Vogel Date: Sun, 1 Nov 2026 11:40:16 -0600 Subject: [PATCH] ci(windows-tests): pass dispatch inputs to PowerShell through env The Test step interpolated the package and files inputs into single-quoted PowerShell source, so a quote in a value broke parsing or ran as code. Bind them as step env values and read them from $env. The empty checks use -not so an unset variable counts as empty, as an empty string did before. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/windows-tests.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/windows-tests.yml b/.github/workflows/windows-tests.yml index 3a70ad5a26a05..639569a696b83 100644 --- a/.github/workflows/windows-tests.yml +++ b/.github/workflows/windows-tests.yml @@ -68,12 +68,16 @@ jobs: # so file-scoped runs call `vp test run` inside the package instead. - name: Test shell: pwsh + env: + PACKAGE: ${{ inputs.package }} + FILES: ${{ inputs.files }} run: | - $package = '${{ inputs.package }}' - $files = '${{ inputs.files }}' - if ($package -eq '') { + $package = $env:PACKAGE + $files = $env:FILES + # An empty input may arrive unset, and `$null -eq ''` is false. + if (-not $package) { vp run --parallel --concurrency-limit 4 --filter '!t3' --filter '!@t3tools/monorepo' test - } elseif ($files -eq '') { + } elseif (-not $files) { vp run --filter "./$package" test } else { Set-Location $package