`pihole flush` generates an error message inside docker containers

[rdwebdesign]

Details

If the command pihole flush (or pihole -f) is executed inside a docker container, an error message is generated:

/opt/pihole/piholeLogFlush.sh: line 107: service: command not found

This happens because the v6 container doesn't have a service command and lines 107 and 113 will fail.

How to reproduce the issue

Execute pihole -f inside the container:

piholetest:/# pihole -f
  [✓] Flushed /var/log/pihole/pihole.log ...
  [✓] Flushed /var/log/pihole/FTL.log ...
  [✓] Flushed /var/log/pihole/webserver.log ...
  [i] Flushing database, DNS resolution temporarily unavailable .../opt/pihole/piholeLogFlush.sh: line 107: service: command not found
/opt/pihole/piholeLogFlush.sh: line 113: service: command not found
  [✓] Deleted  queries from long-term query database

These common fixes didn't work for my issue

• I have tried removing/destroying my container, and re-creating a new container
• I have tried fresh volume data by backing up and moving/removing the old volume data
• I have tried running the stock docker run example(s) in the readme (removing any customizations I added)
• I have tried a newer or older version of Docker Pi-hole (depending what version the issue started in for me)
• I have tried running without my volume data mounts to eliminate volumes as the cause

If the above debugging / fixes revealed any new information note it here.
Add any other debugging steps you've taken or theories on root cause that may help.

[yubiuser]

pi-hole/pi-hole#6391

Duplicate of pi-hole/pi-hole#6390

[rdwebdesign]

Hmm...
I searched for similar issues only on docker-pi-hole repo, but I think your core PR will break log rotation in containers.

Maybe we can find a way to stop FTL, delete records and restart FTL in a container, but until then we need this function. An alternative would be to create a complete new function to execute log rotation.

[dschaper]

Typically there is no log rotation function inside a running container. Any function like that is handled by the host system if logs are located on a volume mount in the container.

Stopping the daemon in the running container will end the container.

I'd just add pihole -f to the list of functions that don't work in the container and thus are not enabled.

[rdwebdesign]

I think a lot of users keep a Pi-hole container running for more than 7 consecutive days and the logs can grow a lot in some cases.

Currently we already have log rotation inside the container.
I think we can disable the log flushing and also keep the rotation if we simply separate these 2 jobs in 2 different functions.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.