StrictFunctionCallsRule: distinguish between "parameter is not true" and "parameter is missing"

Author: kukulich

src/Rules/StrictCalls/StrictFunctionCallsRule.php

@@ -51,14 +51,13 @@ public function processNode(\PhpParser\Node $node, \PHPStan\Analyser\Scope $scop
 		}
 
 		$argumentPosition = $this->functionArguments[$functionName];
-		$message = sprintf('Call to function %s() requires parameter #%d to be true.', $functionName, $argumentPosition + 1);
 		if (!array_key_exists($argumentPosition, $node->args)) {
-			return [$message];
+			return [sprintf('Call to function %s() requires parameter #%d to be set.', $functionName, $argumentPosition + 1)];
 		}
 
 		$argumentType = $scope->getType($node->args[$argumentPosition]->value);
 		if (!$argumentType instanceof \PHPStan\Type\TrueBooleanType) {
-			return [$message];
+			return [sprintf('Call to function %s() requires parameter #%d to be true.', $functionName, $argumentPosition + 1)];
 		}
 
 		return [];

tests/Rules/StrictCalls/StrictFunctionCallsRuleTest.php

@@ -16,51 +16,51 @@ public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/strict-calls.php'], [
 			[
-				'Call to function in_array() requires parameter #3 to be true.',
+				'Call to function in_array() requires parameter #3 to be set.',
 				5,
 			],
 			[
 				'Call to function in_array() requires parameter #3 to be true.',
 				7,
 			],
 			[
-				'Call to function in_array() requires parameter #3 to be true.',
+				'Call to function in_array() requires parameter #3 to be set.',
 				8,
 			],
 			[
-				'Call to function array_search() requires parameter #3 to be true.',
+				'Call to function array_search() requires parameter #3 to be set.',
 				10,
 			],
 			[
 				'Call to function array_search() requires parameter #3 to be true.',
 				12,
 			],
 			[
-				'Call to function array_search() requires parameter #3 to be true.',
+				'Call to function array_search() requires parameter #3 to be set.',
 				13,
 			],
 			[
-				'Call to function base64_decode() requires parameter #2 to be true.',
+				'Call to function base64_decode() requires parameter #2 to be set.',
 				15,
 			],
 			[
 				'Call to function base64_decode() requires parameter #2 to be true.',
 				17,
 			],
 			[
-				'Call to function base64_decode() requires parameter #2 to be true.',
+				'Call to function base64_decode() requires parameter #2 to be set.',
 				18,
 			],
 			[
-				'Call to function array_keys() requires parameter #3 to be true.',
+				'Call to function array_keys() requires parameter #3 to be set.',
 				20,
 			],
 			[
 				'Call to function array_keys() requires parameter #3 to be true.',
 				22,
 			],
 			[
-				'Call to function array_keys() requires parameter #3 to be true.',
+				'Call to function array_keys() requires parameter #3 to be set.',
 				23,
 			],
 		]);