lint

Author: shmax

src/PhpDoc/TypeNodeResolver.php

@@ -103,7 +103,6 @@
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeAlias;
-use PHPStan\Type\GenericTypeAliasType;
 use PHPStan\Type\TypeAliasResolver;
 use PHPStan\Type\TypeAliasResolverProvider;
 use PHPStan\Type\TypeCombinator;

src/Rules/MissingTypehintCheck.php

@@ -18,11 +18,11 @@
 use PHPStan\Type\Generic\GenericStaticType;
 use PHPStan\Type\Generic\TemplateType;
 use PHPStan\Type\Generic\TemplateTypeHelper;
+use PHPStan\Type\GenericTypeAliasType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
-use PHPStan\Type\GenericTypeAliasType;
 use PHPStan\Type\TypeTraverser;
 use Traversable;
 use function array_filter;

src/Type/GenericTypeAliasType.php

@@ -11,6 +11,7 @@
 use PHPStan\Type\Generic\TemplateTypeVarianceMap;
 use PHPStan\Type\Traits\LateResolvableTypeTrait;
 use PHPStan\Type\Traits\NonGeneralizableTypeTrait;
+use function array_keys;
 use function array_map;
 use function array_merge;
 use function array_unique;
@@ -68,9 +69,11 @@ public function getMissingRequiredParamNames(): array
 	{
 		$missing = [];
 		foreach ($this->paramNames as $i => $name) {
-			if (!isset($this->args[$i]) && $this->defaults[$i] === null) {
-				$missing[] = $name;
+			if (isset($this->args[$i]) || $this->defaults[$i] !== null) {
+				continue;
 			}
+
+			$missing[] = $name;
 		}
 
 		return $missing;
@@ -136,7 +139,7 @@ public function isResolvable(): bool
 			}
 		}
 
-		foreach ($this->paramNames as $i => $name) {
+		foreach (array_keys($this->paramNames) as $i) {
 			if (!isset($this->args[$i]) && $this->defaults[$i] === null) {
 				return false;
 			}
@@ -227,4 +230,3 @@ public function toPhpDocNode(): TypeNode
 	}
 
 }
-

src/Type/TypeAlias.php

@@ -17,7 +17,6 @@
 use function array_map;
 use function array_values;
 use function count;
-use function array_fill;
 
 final class TypeAlias
 {