There are duplicate pieces of code that de ref

[matyhtf]

• pecl-database-pdo_oci/oci_statement.c

  Line 248 in e7a355e

  if (Z_ISREF(param->parameter)) {

• pecl-database-pdo_oci/oci_statement.c

  Line 293 in e7a355e

  if (Z_ISREF(param->parameter))

Why is it necessary to detect the reference again after the oci_stmt_param_hook() function has already dereferenced this variable?

I have some doubts about this, could you please help me explain it? Thank you.

Additionally, there is a inconsistency in the style between these two pieces of code. oci_bind_output_cb uses curly braces {} in the if branch code, whereas oci_bind_input_cb does not.

[sharadraju]

Can you please explain why this is an issue?
The reference detection in Line 248 is done in a completely different function (oci_bind_output_cb) as compared to the reference detection in Line 293 in oci_stmt_param_hook() function.