Skip to content

fix(automation): pair widget-key with key_up #5

Description

@phall1

Problem

dispatchAutomationWidgetKey emits only .key_down (src/runtime/automation_widget_dispatch.zig:514). Real keystrokes are a press/release pair, and stateful key-lifetime consumers can retain their latch, making a repeated automated chord behave differently from hardware.

Scope

Dispatch a matching .key_up with the same key/modifiers/timestamp after the synthesized press. Do not add a second automation verb: existing widget-key scripts should continue to mean one whole keystroke.

Acceptance

  • Repeating an automated chord reaches the target twice.
  • Existing single-key behavior remains unchanged.
  • Coverage proves the emitted input sequence is down then up.

Upstream candidate

Small, self-contained port from the Cockpit fork; suitable for a signed upstream PR after rebasing on current upstream.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions