fix(unit tests): Fix more tests

Author: bmuenzenmeyer

core/lib/parameter_hunter.js

@@ -254,7 +254,7 @@ const parameter_hunter = function () {
 
           //find the partial's name and retrieve it
           const partialName = pMatch.match(/([\w\-\.\/~]+)/g)[0];
-          const partialPattern = jsonCopy(getPartial(path.normalize(partialName), patternlab, `partial pattern ${partialName}`));
+          const partialPattern = jsonCopy(getPartial(partialName, patternlab, `partial pattern ${partialName}`));
 
           //if we retrieved a pattern we should make sure that its extendedTemplate is reset. looks to fix #190
           if (!partialPattern.extendedTemplate) {

test/files/_patterns/00-test/sticky-comment-full.mustache

@@ -1 +1 @@
-{{> 00-test\comment(description: 'A life is like a garden. Perfect moments can be had, but not preserved, except in memory.') }}
+{{> 00-test/comment(description: 'A life is like a garden. Perfect moments can be had, but not preserved, except in memory.') }}

test/files/_patterns/00-test/sticky-comment-verbose.mustache

@@ -7,7 +7,7 @@ const getPartial = require('../core/lib/get');
 
 const patterns_dir = './test/files/_patterns';
 
-tap.test('get_pattern_by_key - returns the fuzzy result when no others found', function (test) {
+tap.test('getPartial - returns the fuzzy result when no others found', function (test) {
   //arrange
   const patternlab = util.fakePatternLab(patterns_dir);
   patternlab.patterns = [];
@@ -27,7 +27,32 @@ tap.test('get_pattern_by_key - returns the fuzzy result when no others found', f
   test.end();
 });
 
-tap.test('get_pattern_by_key - returns the exact key if found', function (test) {
+tap.test('getPartial - returns the verbose result if found', function (test) {
+  //arrange
+  const patternlab = util.fakePatternLab(patterns_dir);
+  patternlab.patterns = [];
+
+  patternlab.patterns.push({
+    patternPartial: 'molecules-primary-nav-jagged',
+    subdir: 'molecules',
+    fileName: 'primary-nav-jagged',
+    verbosePartial: 'molecules/primary-nav-jagged'
+  }, {
+    patternPartial: 'molecules-primary-nav',
+    subdir: 'molecules',
+    fileName: 'molecules-primary-nav',
+    verbosePartial: 'molecules/primary-nav'
+  });
+
+  //act
+  var result = getPartial('molecules/primary-nav', patternlab);
+
+  //assert
+  test.equals(result, patternlab.patterns[1]);
+  test.end();
+});
+
+tap.test('getPartial - returns the exact key if found', function (test) {
   //arrange
   const patternlab = util.fakePatternLab(patterns_dir);
   patternlab.patterns = [];

test/get_tests.js

@@ -94,14 +94,6 @@ tap.test('buildPatterns', function () {
         test.equals(util.sanitized(pattern.patternPartialCode), util.sanitized(`<h1></h1><p>A life is like a garden. Perfect moments can be had, but not preserved, except in memory.</p>`));
         test.end();
       });
-
-      tap.test('parameter hunter finds and extends templates with fully-pathed partials', function (test) {
-        var pattern = get('test-sticky-comment-full', patternlab);
-        test.equals(util.sanitized(pattern.patternPartialCode), util.sanitized(`<h1></h1><p>A life is like a garden. Perfect moments can be had, but not preserved, except in memory.</p>`));
-        test.end();
-      });
-
-
     }
   };
 

test/index_tests.js

@@ -39,7 +39,7 @@ tap.test('parameter hunter finds and extends templates', function (test) {
   }).catch(test.threw);
 });
 
-tap.only('parameter hunter finds and extends templates with verbose partials', function (test) {
+tap.test('parameter hunter finds and extends templates with verbose partials', function (test) {
   //arrange
   const pl = util.fakePatternLab(testPatternsPath);
 
@@ -56,35 +56,12 @@ tap.only('parameter hunter finds and extends templates with verbose partials', f
     //act
     parameter_hunter.find_parameters(testPattern, pl).then(() => {
       //assert
-      test.equals(util.sanitized(testPattern.extendedTemplate), util.sanitized('<h1></h1><p>A life is like a garden. Perfect moments can be had, but not preserved, except in memory.</p>'));
+      test.equals(util.sanitized(testPattern.extendedTemplate), util.sanitized('<h1>{{foo}}</h1><p>A life is like a garden. Perfect moments can be had, but not preserved, except in memory.</p>'));
       test.end();
     }).catch(test.threw);
   }).catch(test.threw);
 });
 
-tap.test('parameter hunter finds and extends templates with fully-pathed partials', function(test) {
-  //arrange
-  const pl = util.fakePatternLab(testPatternsPath);
-
-  var commentPath = path.join('00-test', 'comment.mustache');
-  var commentPattern = loadPattern(commentPath, pl);
-
-  var testPatternPath = path.join('00-test', 'sticky-comment-full.mustache');
-  var testPattern = loadPattern(testPatternPath, pl);
-
-  var p1 = processIterative(commentPattern, pl);
-  var p2 = processIterative(testPattern, pl);
-
-  Promise.all([p1, p2]).then(() => {
-    //act
-    parameter_hunter.find_parameters(testPattern, pl).then(() => {
-      //assert
-      test.equals(util.sanitized(testPattern.extendedTemplate), util.sanitized('<h1></h1><p>A life is like a garden. Perfect moments can be had, but not preserved, except in memory.</p>'));
-      test.end();
-    });
-  });
-});
-
 //previous tests were for unquoted parameter keys and single-quoted values.
 //test other quoting options.
 tap.test('parameter hunter parses parameters with unquoted keys and unquoted values', function (test) {