Skip to content

Commit 9a7bda0

Browse files
committed
refactor: cleanup + minor fixes
1 parent 367893a commit 9a7bda0

3 files changed

Lines changed: 5 additions & 9 deletions

File tree

packages/uikit-workshop/src/scripts/components/modal-styleguide.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ export const modalStyleguide = {
166166
patternQueryInfo(patternData, iframePassback, switchText) {
167167
// send a message to the pattern
168168
try {
169-
let obj = JSON.stringify({
169+
const obj = JSON.stringify({
170170
event: 'patternLab.patternQueryInfo',
171171
patternData,
172172
iframePassback,

packages/uikit-workshop/src/scripts/components/modal-viewer.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ export const modalViewer = {
207207
}
208208

209209
// add active class to called element and scroll to it
210-
for (i = 0; i < els.length; ++i) {
210+
for (let i = 0; i < els.length; ++i) {
211211
if (i + 1 == pos) {
212212
els[i].classList.add('pl-is-active');
213213
$('.pl-js-pattern-info').animate(
@@ -255,8 +255,6 @@ export const modalViewer = {
255255
* @param {Object} event info
256256
*/
257257
receiveIframeMessage(event) {
258-
var els, i;
259-
260258
// does the origin sending the message match the current host? if not dev/null the request
261259
if (
262260
window.location.protocol !== 'file:' &&
@@ -277,8 +275,8 @@ export const modalViewer = {
277275
modalViewer.active === false &&
278276
data.patternpartial !== undefined &&
279277
data.patternpartial.indexOf('viewall-') === 0 &&
280-
config.defaultShowPatternInfo !== undefined &&
281-
config.defaultShowPatternInfo
278+
window.config.defaultShowPatternInfo !== undefined &&
279+
window.config.defaultShowPatternInfo
282280
) {
283281
modalViewer.queryPattern(false);
284282
} else if (modalViewer.active === true) {

packages/uikit-workshop/src/scripts/components/styleguide.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -629,9 +629,7 @@ import { patternFinder } from './pattern-finder';
629629
try {
630630
data =
631631
typeof event.data !== 'string' ? event.data : JSON.parse(event.data);
632-
} catch (e) {
633-
throw Error(e);
634-
}
632+
} catch (e) {}
635633

636634
if (data.event !== undefined) {
637635
if (data.event === 'patternLab.pageLoad') {

0 commit comments

Comments
 (0)