Skip to content

Commit 4f13807

Browse files
committed
fix: a11y issue on a missing description of that complementary icon
Firefox a11y analysis on developer tools is mentioning the missing description on that complementary icon, so we could easily remove it from the accessibility tree
1 parent 7dee3b3 commit 4f13807

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/uikit-workshop/views-twig/partials/patternSection.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<button class="pl-c-pattern__extra-toggle pl-js-pattern-extra-toggle" id="pl-pattern-extra-toggle-{{partial.patternPartial}}" data-patternpartial="{{ partial.patternPartial }}" title="View Pattern Info">
2020
<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--expand">Expand</span>
2121
<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--collapse">Collapse</span>
22-
<div class="pl-c-pattern__toggle-icon-wrapper">
22+
<div class="pl-c-pattern__toggle-icon-wrapper" aria-hidden="true">
2323
<svg viewBox="0 0 16 16" width="20" height="20" class="pl-c-pattern__toggle-icon pl-c-pattern__toggle-icon--expand">
2424
<path fill="currentColor" d="M9 11.5l1.5 1.5 5-5-5-5-1.5 1.5 3.5 3.5z"></path>
2525
<path fill="currentColor" d="M7 4.5l-1.5-1.5-5 5 5 5 1.5-1.5-3.5-3.5z"></path>

packages/uikit-workshop/views/partials/patternSection.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<button class="pl-c-pattern__extra-toggle pl-js-pattern-extra-toggle" id="pl-pattern-extra-toggle-{{ patternPartial }}" data-patternpartial="{{ patternPartial }}" title="View Pattern Info">
1919
<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--expand">Expand</span>
2020
<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--collapse">Collapse</span>
21-
<div class="pl-c-pattern__toggle-icon-wrapper">
21+
<div class="pl-c-pattern__toggle-icon-wrapper" aria-hidden="true">
2222
<svg viewBox="0 0 16 16" width="20" height="20" class="pl-c-pattern__toggle-icon pl-c-pattern__toggle-icon--expand">
2323
<path fill="currentColor" d="M9 11.5l1.5 1.5 5-5-5-5-1.5 1.5 3.5 3.5z"></path>
2424
<path fill="currentColor" d="M7 4.5l-1.5-1.5-5 5 5 5 1.5-1.5-3.5-3.5z"></path>

0 commit comments

Comments
 (0)