fix(core): Fix tests

Author: bmuenzenmeyer

packages/core/src/lib/patternlab.js

@@ -213,16 +213,12 @@ module.exports = class PatternLab {
         'utf8'
       );
     } catch (ex) {
-      logger.info(ex);
+      logger.error(ex);
       logger.error(
         '\nERROR: missing an essential file from ' +
           paths.source.patternlabFiles +
           ". Pattern Lab won't work without this file.\n"
       );
-
-      // GTP: it seems increasingly naughty as we refactor to just unilaterally do this here,
-      // but whatever. For now.
-      process.exit(1);
     }
 
     this.data = Object.assign({}, this.data, additionalData);

packages/core/test/annotation_exporter_tests.js

@@ -3,7 +3,7 @@
 var tap = require('tap');
 
 var extend = require('util')._extend;
-var anPath = './test/files/';
+var anPath = `${__dirname}/files/`;
 
 function createFakePatternLab(anPath, customProps) {
   var pl = {

packages/core/test/data_loader_tests.js

@@ -5,7 +5,7 @@ const tap = require('tap');
 tap.test('loadDataFromFile - Load ', function(test) {
   const fs = require('fs-extra'),
     dataLoader = require('../src/lib/data_loader')(),
-    data_dir = './test/files/_data/';
+    data_dir = `${__dirname}/files/_data/`;
 
   let data = dataLoader.loadDataFromFile(data_dir + 'foo', fs);
   test.equals(data.foo, 'bar');

packages/core/test/lineage_hunter_tests.js

@@ -28,7 +28,7 @@ function createFakeEmptyErrorPattern() {
 }
 
 function createBasePatternLabObject() {
-  var patterns_dir = './test/files/_patterns/';
+  var patterns_dir = `${__dirname}/files/_patterns/`;
   var pl = {};
   (pl.graph = PatternGraph.empty()),
     (pl.config = {
@@ -37,7 +37,7 @@ function createBasePatternLabObject() {
           patterns: patterns_dir,
         },
         public: {
-          patterns: './test/public/_patterns',
+          patterns: `${__dirname}/public/_patterns`,
         },
       },
       outputFileSuffixes: {

packages/core/test/loadPattern_tests.js

@@ -10,7 +10,7 @@ var config = require('./util/patternlab-config.json');
 
 patternEngines.loadAllEngines(config);
 
-const patterns_dir = './test/files/_patterns';
+const patterns_dir = `${__dirname}/files/_patterns`;
 
 tap.test('loadPattern - returns null if file is not a pattern', function(test) {
   //arrange

packages/core/test/markdown_parser_tests.js

@@ -12,7 +12,7 @@ tap.test(
   function(test) {
     //arrange
     var markdownFileName = path.resolve(
-      './test/files/_patterns/00-test/02-baz.md'
+      `${__dirname}/files/_patterns/00-test/02-baz.md`
     );
     var markdownFileContents = fs.readFileSync(markdownFileName, 'utf8');
 
@@ -30,7 +30,7 @@ tap.test(
   function(test) {
     //arrange
     var markdownFileName = path.resolve(
-      './test/files/_patterns/00-test/01-bar.md'
+      `${__dirname}/files/_patterns/00-test/01-bar.md`
     );
     var markdownFileContents = fs.readFileSync(markdownFileName, 'utf8');
 
@@ -50,7 +50,7 @@ tap.test(
 tap.test('parses frontmatter only when no markdown present', function(test) {
   //arrange
   var markdownFileName = path.resolve(
-    './test/files/_patterns/00-test/03-styled-atom.md'
+    `${__dirname}/files/_patterns/00-test/03-styled-atom.md`
   );
   var markdownFileContents = fs.readFileSync(markdownFileName, 'utf8');
 

packages/core/test/pattern_graph_tests.js

@@ -14,7 +14,7 @@ var patternlab = {
   config: {
     paths: {
       public: {
-        root: './test/public',
+        root: `${__dirname}/public`,
       },
     },
   },

packages/core/test/patternlab_tests.js

@@ -31,7 +31,7 @@ plEngineModule.__set__({
 tap.test(
   'buildPatternData - should merge all JSON files in the data folder except listitems',
   function(test) {
-    var data_dir = './test/files/_data/';
+    const data_dir = `${__dirname}/files/_data/`;
 
     var pl = new plEngineModule(config);
     var dataResult = pl.buildPatternData(data_dir, fs);
@@ -45,7 +45,7 @@ tap.test(
 tap.test('buildPatternData - can load json, yaml, and yml files', function(
   test
 ) {
-  const data_dir = './test/files/_data/';
+  const data_dir = `${__dirname}/files/_data/`;
 
   var pl = new plEngineModule(config);
   var dataResult = pl.buildPatternData(data_dir, fs);

packages/core/test/processRecursive_tests.js

@@ -14,7 +14,7 @@ var config = require('./util/patternlab-config.json');
 
 engineLoader.loadAllEngines(config);
 
-const patterns_dir = './test/files/_patterns';
+const patterns_dir = `${__dirname}/files/_patterns`;
 
 tap.test('processRecursive recursively includes partials', function(test) {
   //assert

packages/core/test/pseudopattern_hunter_tests.js

@@ -15,8 +15,8 @@ var engineLoader = require('../src/lib/pattern_engines');
 engineLoader.loadAllEngines(config);
 
 var fs = require('fs-extra');
-var patterns_dir = './test/files/_patterns/';
-var public_patterns_dir = './test/public/patterns';
+var patterns_dir = `${__dirname}/files/_patterns/`;
+var public_patterns_dir = `${__dirname}/test/public/patterns`;
 
 function stubPatternlab() {
   var pl = {};