fix(unit tests): Fix test

Author: bmuenzenmeyer

core/lib/decompose.js

@@ -41,7 +41,7 @@ function expandPartials(foundPatternPartials, patternlab, currentPattern) {
       }
 
       //recurse through nested partials to fill out this extended template.
-      processRecursive(partialPath, patternlab).then(() => { //eslint-disable-line no-loop-func
+      return processRecursive(partialPath, patternlab).then(() => { //eslint-disable-line no-loop-func
         //complete assembly of extended template
         //create a copy of the partial so as to not pollute it after the getPartial call.
         var partialPattern = getPartial(partial, patternlab);
@@ -55,6 +55,7 @@ function expandPartials(foundPatternPartials, patternlab, currentPattern) {
         //this is what we came here for
         logger.debug(`within ${currentPattern.patternPartial}, replacing extendedTemplate partial ${foundPartial} with ${cleanPartialPattern.patternPartial}'s extededTemplate`);
         currentPattern.extendedTemplate = currentPattern.extendedTemplate.replace(foundPartial, cleanPartialPattern.extendedTemplate);
+        return Promise.resolve();
       });
     });
   }).catch(reason => {

core/lib/processRecursive.js

@@ -23,6 +23,7 @@ module.exports = function (file, patternlab) {
   //call our helper method to actually unravel the pattern with any partials
   return decompose(currentPattern, patternlab)
     .catch(reason => {
+      console.log(reason)
       logger.error(reason);
     });
 };

test/processRecursive_tests.js

@@ -8,6 +8,7 @@ const buildListItems = require('../core/lib/buildListItems');
 const pa = require('../core/lib/pattern_assembler');
 const pattern_assembler = new pa();
 const engineLoader = require('../core/lib/pattern_engines');
+const getPartial = require('../core/lib/get');
 const processRecursive = require('../core/lib/processRecursive');
 const processIterative = require('../core/lib/processIterative');
 
@@ -237,28 +238,37 @@ tap.test('processRecursive - ensure deep-nesting works', function (test) {
   var p2 = processIterative(templatePattern, patternlab);
   var p3 = processIterative(pagesPattern, patternlab);
 
-  Promise.all([p1, p2, p3]).then(() => {
+  return Promise.all([
+    p1,
+    p2,
+    p3,
+    processRecursive(atomPath, patternlab),
+    processRecursive(templatePath, patternlab),
+    processRecursive(pagesPath, patternlab)
+  ]).then(() => {
     //act
-    processRecursive(pagesPath, patternlab).then(() => {
+    return test.test('processRecursive - ensure deep-nesting works2', function (tt) {
       //assert
       const expectedCleanValue = 'bar';
       const expectedSetValue = 'bar';
 
       //this is the "atom" - it should remain unchanged
-      test.equals(util.sanitized(atomPattern.template), expectedCleanValue);
-      test.equals(util.sanitized(atomPattern.extendedTemplate), expectedCleanValue);
+      tt.equals(util.sanitized(atomPattern.template), expectedCleanValue);
+      tt.equals(util.sanitized(atomPattern.extendedTemplate), expectedCleanValue);
 
       //this is the "template pattern" - it should have an updated extendedTemplate but an unchanged template
-      test.equals(util.sanitized(templatePattern.template), '{{> test-bar }}');
-      test.equals(util.sanitized(templatePattern.extendedTemplate), expectedSetValue);
+      tt.equals(util.sanitized(templatePattern.template), '{{> test-bar }}');
+      tt.equals(util.sanitized(templatePattern.extendedTemplate), expectedSetValue);
 
       //this is the "pages pattern" - it should have an updated extendedTemplate equal to the template pattern but an unchanged template
-      test.equals(util.sanitized(pagesPattern.template), '{{> test-foo }}');
-      test.equals(util.sanitized(pagesPattern.extendedTemplate), expectedSetValue);
+      tt.equals(util.sanitized(pagesPattern.template), '{{> test-foo }}');
+      tt.equals(util.sanitized(pagesPattern.extendedTemplate), expectedSetValue);
+      tt.end();
       test.end();
-    }).catch(test.threw);
-  }).catch(test.threw);
-});
+    });
+
+  })
+}).catch(tap.threw);
 
 tap.test('processRecursive - 685 ensure listitems data is used', function (test) {
   //arrange