diff --git a/packit_service/config.py b/packit_service/config.py index e31ec365d..851830a2f 100644 --- a/packit_service/config.py +++ b/packit_service/config.py @@ -90,7 +90,7 @@ def __eq__(self, other: object) -> bool: if not isinstance(other, MRTarget): raise NotImplementedError() - return self.repo == other.repo and self.branch == self.branch + return self.repo == other.repo and self.branch == other.branch class ServiceConfig(Config): diff --git a/tests/unit/test_config.py b/tests/unit/test_config.py index 6f7f81aa3..e6d326b0f 100644 --- a/tests/unit/test_config.py +++ b/tests/unit/test_config.py @@ -83,6 +83,14 @@ def test_parse_valid(service_config_valid): assert config.package_config_path_override is None +def test_mr_target_membership_respects_branch(service_config_valid): + config = ServiceConfig.get_from_dict(service_config_valid) + assert MRTarget("redhat/centos-stream/src/.+", "c9s") in config.gitlab_mr_targets_handled + assert ( + MRTarget("redhat/centos-stream/src/.+", "rawhide") not in config.gitlab_mr_targets_handled + ) + + def test_parse_optional_values(service_config_valid): """When optional values are set, they are correctly parsed""" config = ServiceConfig.get_from_dict(